FS/XFS testing framework
 help / color / mirror / Atom feed
From: Zorro Lang <zlang@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] generic/366: check minimum dio size correctly
Date: Tue, 16 Jun 2026 04:13:22 +0800	[thread overview]
Message-ID: <ajBbo5LX-1tk-y3_@zlang-mailbox> (raw)
In-Reply-To: <20260615133331.GA26132@lst.de>

On Mon, Jun 15, 2026 at 03:33:31PM +0200, Christoph Hellwig wrote:
> On Mon, Jun 15, 2026 at 02:58:11AM +0800, Zorro Lang wrote:
> > > +	blksz=`$here/src/min_dio_alignment $SCRATCH_MNT $SCRATCH_DEV`
> > > +	if [[ $blksz -gt 512 ]]; then
> > > +		_notrun "512 byte dio alignment required"
> > > +	fi
> > 
> > Do we need to check this in every iteration?
> 
> We don't, but we also don't want to do an extra mount just to check
> the feature.

Oh, if we only need to run it once, how about:

blksz=""
for (( i = 0; i < $iterations; i++)); do
    ...
    if [ -z "$blksz" ];then
	    blksz=`$here/src/min_dio_alignment $SCRATCH_MNT $SCRATCH_DEV`
        if [[ $blksz -gt 512 ]]; then
            _notrun "512 byte dio alignment required"
        fi
    fi
...


Thanks,
Zorro

> 
> 

  reply	other threads:[~2026-06-15 20:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-08  7:00 [PATCH] generic/366: check minimum dio size correctly Christoph Hellwig
2026-06-14 18:58 ` Zorro Lang
2026-06-15 13:33   ` Christoph Hellwig
2026-06-15 20:13     ` Zorro Lang [this message]
2026-06-16  5:28       ` Christoph Hellwig
2026-06-16  6:13         ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ajBbo5LX-1tk-y3_@zlang-mailbox \
    --to=zlang@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox