Re: mkfs.xfs "concurrency" change concerns

[Christoph Hellwig <hch@infradead.org>]

On Wed, Jun 17, 2026 at 10:43:10AM +0900, Shin'ichiro Kawasaki wrote:
> Just FYI, here's my command line logs. nullb0 and nullb1 are 8GiB memory backed
> null_blk devices. I also tried each of "-d concurrency=0", "-l concurrency=0"
> and "-r concurrency=0" seperately, and observed the same failures. I used the
> kernel at xfs/for-next on Jun/12 and fstests tag v2026.05.17. The fstests
> alraday has the commit by Lukas ffc8bad17e5b ("xfs/21{6,7} Use default -l
> concurrency=0 on mkfs.xfs that supports it").

Both xfs/078 and xfs/216 don't actually use MKFS_OPTIONS :(

Can you try the quick hack patch below:

diff --git a/tests/xfs/078 b/tests/xfs/078
index 6057aeea1..c477f6cfb 100755
--- a/tests/xfs/078
+++ b/tests/xfs/078
@@ -57,7 +57,7 @@ _grow_loop()
 	$XFS_IO_PROG -f -c "truncate $original" $LOOP_IMG
 	loop_dev=`_create_loop_device $LOOP_IMG $bsize`
 
-	dparam=""
+	dparam="-d concurrency=0 -l concurrency=0 -r concurrency=0"
 	if [ -n "$agsize" ]; then
 		dparam="-d agsize=$agsize"
 	fi
diff --git a/tests/xfs/216 b/tests/xfs/216
index 1749647c1..ded3d30af 100755
--- a/tests/xfs/216
+++ b/tests/xfs/216
@@ -22,11 +22,7 @@ _cleanup()
 
 _require_scratch
 _scratch_mkfs_xfs >/dev/null 2>&1
-if _scratch_mkfs_xfs_supports_concurrency -l >> $seqres.full 2>&1; then
-	loop_mkfs_opts="-l concurrency=0"
-else
-	loop_mkfs_opts=""
-fi
+loop_mkfs_opts="-d concurrency=0 -l concurrency=0 -r concurrency=0"
 _scratch_mount
 
 _require_loop