From: Zorro Lang <zlang@kernel.org>
To: German Maglione <gmaglione@redhat.com>
Cc: fstests@vger.kernel.org, brauner@kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] generic/633: add _require_acls for tcore_acls() ACL dependency
Date: Sun, 21 Jun 2026 23:54:58 +0800 [thread overview]
Message-ID: <ajgIp_6kmKxPpZuP@zlang-mailbox> (raw)
In-Reply-To: <20260618-xfstests-tcore-acls-fixes-v1-2-45a1aec1d99d@redhat.com>
On Thu, Jun 18, 2026 at 12:11:54PM +0200, German Maglione wrote:
> generic/633 runs --test-core which includes tcore_acls(). Without
> _require_acls, the test fails instead of being skipped on filesystems
> that lack ACL support.
>
> Signed-off-by: German Maglione <gmaglione@redhat.com>
> ---
> tests/generic/633 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/generic/633 b/tests/generic/633
> index d75d4dc860d3b78e5fe11b538e3aba4e9ab477e1..90d24f099bc732d5db209f8d014ddaeb042985b2 100755
> --- a/tests/generic/633
> +++ b/tests/generic/633
> @@ -14,6 +14,7 @@ _begin_fstest auto quick atime attr cap idmapped io_uring mount perms rw unlink
>
> _require_test
> _require_chown
> +_require_acls
_require_acls is in common/attr which isn't imported automatically.
I'll help to do:
. ./common/attr
when I merge this patch.
Reviewed-by: Zorro Lang <zlang@kernel.org>
Thanks,
Zorro
>
> echo "Silence is golden"
>
>
> --
> 2.49.0
>
next prev parent reply other threads:[~2026-06-21 15:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 10:11 [PATCH 0/2] vfstest: fix tcore_acls() cleanup bug and missing _require_acls German Maglione
2026-06-18 10:11 ` [PATCH 1/2] vfstest: move sys_umount2() to cleanup path in tcore_acls() German Maglione
2026-06-21 15:56 ` Zorro Lang
2026-06-18 10:11 ` [PATCH 2/2] generic/633: add _require_acls for tcore_acls() ACL dependency German Maglione
2026-06-21 15:54 ` Zorro Lang [this message]
2026-06-19 8:21 ` [PATCH 0/2] vfstest: fix tcore_acls() cleanup bug and missing _require_acls Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajgIp_6kmKxPpZuP@zlang-mailbox \
--to=zlang@kernel.org \
--cc=brauner@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=gmaglione@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox