From: Zorro Lang <zlang@kernel.org>
To: Jan Prusakowski <jprusakowski@google.com>
Cc: Christoph Hellwig <hch@infradead.org>,
fstests@vger.kernel.org, jaegeuk@kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH] generic/064: allow 50 extents on F2FS after fcollapse
Date: Tue, 30 Jun 2026 00:37:29 +0800 [thread overview]
Message-ID: <akKd2IImO7bRjVV2@zlang-mailbox> (raw)
In-Reply-To: <ajuLORVplOvEXvnI@infradead.org>
On Wed, Jun 24, 2026 at 12:46:01AM -0700, Christoph Hellwig wrote:
> On Mon, Jun 22, 2026 at 07:04:38AM +0000, Jan Prusakowski wrote:
> > On F2FS, generic/064 fails with "extents mismatched before = 1 after =
> > 50" following multiple fcollapse (collapse range) operations.
> >
> > To ensure crash consistency and checkpoint integrity, F2FS forbids
> > in-place SSR (Summary Standalone Replacement) overwrites on valid
> > checkpointed blocks. When collapse range shifts blocks, F2FS allocates
> > new data pages in LFS mode (out-of-place log writes). As a result,
> > sequential collapse range calls rewrite shifted blocks at new log
> > locations, intentionally leaving the file with 50 extents.
>
> This sounds odd. The test allocates a contigous range and then just does
> insert/collapse on it, which should not lead to any new data block
> allocations. Given that the test works fine on zoned XFS and btrfs
> with strict out of place write policies we know it does not require
> overwriting blocks to work as well.
>
> So I think something is fishy in f2fs if needs to allocate data blocks
> here.
I have the same question with Christoph. Shouldn't fcollapse in F2FS just
remap the metadata instead of allocating new data blocks?
>
next prev parent reply other threads:[~2026-06-29 16:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 7:04 [PATCH] generic/064: allow 50 extents on F2FS after fcollapse Jan Prusakowski
2026-06-23 8:46 ` [f2fs-dev] " Chao Yu
2026-06-24 7:46 ` Christoph Hellwig
2026-06-29 16:37 ` Zorro Lang [this message]
2026-06-30 12:09 ` [f2fs-dev] " Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akKd2IImO7bRjVV2@zlang-mailbox \
--to=zlang@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=jaegeuk@kernel.org \
--cc=jprusakowski@google.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox