From: Christoph Hellwig <hch@infradead.org>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc: Zorro Lang <zlang@redhat.com>,
fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 3/5] generic/746: skip on zoned btrfs
Date: Mon, 20 Jul 2026 10:37:38 -0700 [thread overview]
Message-ID: <al5c4krF3A03HZ1o@infradead.org> (raw)
In-Reply-To: <20260720111849.1659111-4-johannes.thumshirn@wdc.com>
On Mon, Jul 20, 2026 at 01:18:47PM +0200, Johannes Thumshirn wrote:
> The test relies on loop device discards punching holes in the backing
> image file (holes are then detected via fiemap on the backing file).
> Zoned btrfs does not support fallocate/punch hole, so fstrim on the
> loop device cannot free space in the backing file and the test cannot
> work.
>
> Skip the test on zoned devices, but only for btrfs so that other
> filesystems (e.g. zoned XFS/f2fs) can still run it.
This should use feature detection and not hard code file systems.
I'm also a bit surprised that zoned btrfs doesn't support hole
punches. Unlike classic unwritten extents there is nothing in a
zone model preventing them from working. Did you try just enabling
hole punches in btrfs?
next prev parent reply other threads:[~2026-07-20 17:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 11:18 [PATCH 0/5] fstests: misc fixes for zoned btrfs Johannes Thumshirn
2026-07-20 11:18 ` [PATCH 1/5] common/btrfs: fix awk field separator in _check_temp_fsid Johannes Thumshirn
2026-07-20 16:44 ` Filipe Manana
2026-07-21 6:43 ` Johannes Thumshirn
2026-07-20 11:18 ` [PATCH 2/5] btrfs/199: skip on zoned devices Johannes Thumshirn
2026-07-20 11:18 ` [PATCH 3/5] generic/746: skip on zoned btrfs Johannes Thumshirn
2026-07-20 17:37 ` Christoph Hellwig [this message]
2026-07-27 9:00 ` Johannes Thumshirn
2026-07-20 11:18 ` [PATCH 4/5] btrfs/284: skip on zoned devices Johannes Thumshirn
2026-07-20 11:18 ` [PATCH 5/5] generic/781: fix copyright Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=al5c4krF3A03HZ1o@infradead.org \
--to=hch@infradead.org \
--cc=fstests@vger.kernel.org \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox