From: "Lukáš Czerner" <lczerner@redhat.com>
To: Zhao Lei <zhaolei@cn.fujitsu.com>
Cc: fstests@vger.kernel.org
Subject: RE: [PATCH v3 2/2] Fix warning of "Usage: _is_block_dev dev"
Date: Fri, 27 Feb 2015 10:45:09 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.00.1502271043160.2188@localhost.localdomain> (raw)
In-Reply-To: <00d201d0522f$f4876980$dd963c80$@cn.fujitsu.com>
> > Simply said
> >
> > _is_block_dev "$TEST_DEV"
> >
> > will return empty string if $TEST_DEV either does not exist or $TEST_DEV itself
> > is empty string. However if someone calls
> >
> > _is_block_dev
> >
> > he'll get an error so he knows that he needs to fix his code.
> >
>
> These 2 way have the respective advantages.
> For me, both way is acceptable as long as it can fix titled bug.
>
> I'll send v4 based on your suggestion, to provide Dave Chinner a selection.
Ok thanks, I think that simply using quotes is better then rewriting
the thing and introducing new helpers. But in the end its Dave's decision
to make.
Thanks!
-Lukas
next prev parent reply other threads:[~2015-02-27 9:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 10:38 [PATCH v2 1/2] xfstests: fix a typo in _require_block_device() Zhaolei
2015-02-26 10:38 ` [PATCH v3 2/2] Fix warning of "Usage: _is_block_dev dev" Zhaolei
2015-02-26 11:29 ` Lukáš Czerner
2015-02-26 12:26 ` Zhao Lei
2015-02-26 13:36 ` Lukáš Czerner
2015-02-27 1:51 ` Zhao Lei
2015-02-27 9:45 ` Lukáš Czerner [this message]
2015-02-26 10:45 ` [PATCH v2 1/2] xfstests: fix a typo in _require_block_device() Lukáš Czerner
2015-02-26 13:38 ` Lukáš Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1502271043160.2188@localhost.localdomain \
--to=lczerner@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=zhaolei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox