FS/XFS testing framework
 help / color / mirror / Atom feed
From: Zorro Lang <zlang@kernel.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: fstests@vger.kernel.org, wqu@suse.com
Subject: Re: [PATCH] generic/800: TEST_DIR, not TEST_MNT
Date: Thu, 20 Aug 2026 00:13:38 +0800	[thread overview]
Message-ID: <aoXVhsgvbc_kCe1J@zlang-mailbox> (raw)
In-Reply-To: <20260819152726.GA6060@frogsfrogsfrogs>

On Wed, Aug 19, 2026 at 08:27:26AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Fix this new test regression:
> 
>  --- /run/fstests/bin/tests/generic/800.out	2026-08-18 09:30:13.655513087 -0700
>  +++ /run/fstests/logs/generic/800.out.bad	2026-08-18 16:30:24.107110215 -0700
>  @@ -1,2 +1,4 @@
>   QA output created by 800
>  +/dio-read-source: Read-only file system

Thanks for catching this! My rootfs wasn't configured as read-only, so
I completely missed it.

Reviewed-by: Zorro Lang <zlang@kernel.org>

>  +dio read failed
>   Silence is golden
>
> Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
> ---
>  tests/generic/800 |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/generic/800 b/tests/generic/800
> index 52a664a17e448b..b79c1a0c052876 100755
> --- a/tests/generic/800
> +++ b/tests/generic/800
> @@ -32,8 +32,8 @@ _cleanup()
>  _scratch_mkfs >> $seqres.full
>  _scratch_mount
>  
> -# Create the 4MiB target file on TEST_MNT as the read source.
> -$XFS_IO_PROG -f -c "pwrite -i /dev/urandom 0 4M" "$TEST_MNT/dio-read-source" >> $seqres.full
> +# Create the 4MiB target file on TEST_DIR as the read source.
> +$XFS_IO_PROG -f -c "pwrite -i /dev/urandom 0 4M" "$TEST_DIR/dio-read-source" >> $seqres.full
>  
>  # Another 4MiB target file on SCRATCH_MNT as the mmap dest
>  $XFS_IO_PROG -f -c "pwrite 0 4M" "$SCRATCH_MNT/mmap-dest" >> $seqres.full
> @@ -42,7 +42,7 @@ read_workload()
>  {
>  	_register_cleanup "wait"
>  	while true; do
> -		$here/src/dio-read-into-mmap "$TEST_MNT/dio-read-source" \
> +		$here/src/dio-read-into-mmap "$TEST_DIR/dio-read-source" \
>  			"$SCRATCH_MNT/mmap-dest" &> /dev/null
>  		if [ $? -ne 0 ]; then
>  			echo "dio read failed"

      reply	other threads:[~2026-08-19 16:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-19 15:27 [PATCH] generic/800: TEST_DIR, not TEST_MNT Darrick J. Wong
2026-08-19 16:13 ` Zorro Lang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aoXVhsgvbc_kCe1J@zlang-mailbox \
    --to=zlang@kernel.org \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox