Re: [PATCH v2 0/3] xfstests: add missing _require_scratch checks

[Zorro Lang <zlang@kernel.org>]

On Thu, Sep 03, 2026 at 03:53:41AM +0000, Prabhakar Pujeri wrote:
> Consolidated resend of the remaining _require_scratch fixes, as
> requested by Zorro.  The first three of this batch (btrfs/333 v3,
> overlay/081 v2, btrfs/273 v2) are already in his local tree.
> 
> v2:
> - Resent as a single series, per Zorro's request.
> - Carry Darrick J. Wong's Reviewed-by (generic/590,735 and generic/795)
>   and Zorro Lang's Reviewed-by (f2fs/015,016); besides message
>   re-formatting there is no code change.
> 
> v1 pieces for reference:
> - generic/590,735: https://lore.kernel.org/fstests/20260831104148.2243-1-prabhakar.pujeri@dell.com/
> - generic/795:     https://lore.kernel.org/fstests/20260902050139.2426-1-prabhakar.pujeri@dell.com/
> - f2fs/015,016:    https://lore.kernel.org/fstests/20260902050133.2413-1-prabhakar.pujeri@dell.com/
> 
> 
> Prabhakar Pujeri (3):
>   generic/590,735: add missing _require_scratch check
>   generic/795: add missing _require_scratch check
>   f2fs/015,016: add missing _require_scratch checks

Hi,

Thanks for this work, I'm wondering why generic/590 and generic/735 are
combined into one patch while generic/795 is split out?

Given that they all just add a single line of _require_scratch. While I think
this could easily be a single patch, if you prefer splitting them up, grouping
them per-directory (generic, f2fs, btrfs, overlay ...) would make sense.

Also, I recall you had a few other similar patches, such as:
  btrfs/333: require scratch before checking encoded reads
  btrfs/273: add missing _require_scratch check
  overlay/081: add missing _require_scratch check

Please bundle all of them into a single patch series (keeping any existing
Reviewed-by tags) so they can be reviewed and merged together.

Thanks,
Zorro

>
>  tests/f2fs/015    | 1 +
>  tests/f2fs/016    | 1 +
>  tests/generic/590 | 1 +
>  tests/generic/735 | 1 +
>  tests/generic/795 | 2 ++
>  5 files changed, 6 insertions(+)
> 
> -- 
> 2.55.0
>