From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Zorro Lang <zlang@kernel.org>, fstests <fstests@vger.kernel.org>,
xfs <linux-xfs@vger.kernel.org>,
Andrey Albershteyn <aalbersh@kernel.org>
Subject: Re: [PATCH] generic/805: mask unmount failures on cleanup
Date: Wed, 14 Oct 2026 22:59:45 -0700 [thread overview]
Message-ID: <atBr0ViKkOt0wZ12@infradead.org> (raw)
In-Reply-To: <20261015033236.GV6253@frogsfrogsfrogs>
On Wed, Oct 14, 2026 at 08:32:36PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> On (what's left of) my NFS-booted QA fleet I get test "failures" like
> this:
>
> --- a/generic/805.out 2026-09-22 13:33:18.326820071 -0700
> +++ b/generic/805.out.bad 2026-10-14 18:58:34.438866321 -0700
> @@ -1,2 +1,4 @@
> QA output created by 805
> Silence is golden
> +umount.nfs: remote share not in 'host:dir' format
> +umount.nfs: /mnt/s: not mounted
>
> This is caused by the _unmount call in _cleanup getting cranky about the
> scratch mount not being mounted despite the -q flag. I think this is
> because umount(8) detects the underlying fs as NFS and delegates
> entirely to umount.nfs, and that program whines.
>
> So fix the test by redirecting the output. We've already decided if the
> test passes or not before we get to cleanup.
We really should not end up here with NFS.
Oh, this test is missing a
_require_block_device $SCRATCH_DEV
so that all the dm magic is skipped when on a non-bdev fs.
prev parent reply other threads:[~2026-10-15 5:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 3:32 [PATCH] generic/805: mask unmount failures on cleanup Darrick J. Wong
2026-10-15 5:59 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atBr0ViKkOt0wZ12@infradead.org \
--to=hch@infradead.org \
--cc=aalbersh@kernel.org \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox