FS/XFS testing framework
 help / color / mirror / Atom feed
From: Zorro Lang <zlang@kernel.org>
To: Jeff Layton <jlayton@kernel.org>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] tools/get_maintainer.pl: accept and ignore --nogit-chief-penguins
Date: Thu, 29 Oct 2026 01:09:39 +0800	[thread overview]
Message-ID: <auId2GI01gShq9uf@zlang-mailbox> (raw)
In-Reply-To: <20261027-b4-v1-1-a87dca9172c9@kernel.org>

On Tue, Oct 27, 2026 at 09:51:54AM -0400, Jeff Layton wrote:
> b4 prep --auto-to-cc passes --nogit-chief-penguins as an option to
> get_maintainer.pl. Ensure that it accepts and ignores it.
> 
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---

Makes sense to me, thanks Jeff!

Reviewed-by: Zorro Lang <zlang@kernel.org>

Just out of curiosity, how did you configure your environment to trigger
this in fstests? Did you symlink "scripts" to "tools" (e.g. ln -s tools scripts),
or did you set some b4 git config :)

Thanks,
Zorro

>  tools/get_maintainer.pl | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/get_maintainer.pl b/tools/get_maintainer.pl
> index 671ffe26a799..02c02eea3e67 100755
> --- a/tools/get_maintainer.pl
> +++ b/tools/get_maintainer.pl
> @@ -31,6 +31,7 @@ my $email_fixes = 1;
>  my $email_list = 1;
>  my $email_moderated_list = 1;
>  my $email_subscriber_list = 0;
> +my $email_git_penguin_chiefs = 0;
>  my $email_git = 0;
>  my $email_git_all_signature_types = 0;
>  my $email_git_blame = 0;
> @@ -228,6 +229,7 @@ if (!GetOptions(
>  		'git-blame!' => \$email_git_blame,
>  		'git-blame-signatures!' => \$email_git_blame_signatures,
>  		'git-fallback!' => \$email_git_fallback,
> +		'git-chief-penguins!' => \$email_git_penguin_chiefs,
>  		'git-min-signatures=i' => \$email_git_min_signatures,
>  		'git-max-maintainers=i' => \$email_git_max_maintainers,
>  		'git-min-percent=i' => \$email_git_min_percent,
> 
> ---
> base-commit: 22348afe338c0f6d540c0d7ef0db749eaa51b218
> change-id: 20261027-b4-5ff755f4716c
> 
> Best regards,
> -- 
> Jeff Layton <jlayton@kernel.org>
> 

  reply	other threads:[~2026-10-28 17:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-27 13:51 [PATCH] tools/get_maintainer.pl: accept and ignore --nogit-chief-penguins Jeff Layton
2026-10-28 17:09 ` Zorro Lang [this message]
2026-10-28 17:18   ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auId2GI01gShq9uf@zlang-mailbox \
    --to=zlang@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=jlayton@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox