FS/XFS testing framework
 help / color / mirror / Atom feed
From: Zorro Lang <zlang@kernel.org>
To: Andrey Albershteyn <aalbersh@kernel.org>
Cc: fstests@vger.kernel.org, preichl@redhat.com
Subject: Re: [PATCH] xfs: add tests using xfs_admin to the admin group
Date: Sat, 21 Nov 2026 20:27:37 +0800	[thread overview]
Message-ID: <awGOJT8NneMmtluk@zlang-mailbox> (raw)
In-Reply-To: <20261119080729.3035971-2-aalbersh@kernel.org>

On Thu, Nov 19, 2026 at 09:07:29AM +0100, Andrey Albershteyn wrote:
> So far, only xfs/156 and xfs/157 are in admin group. Let's include all
> the tests which use this script into the group. This script is not that
> complex, so, this increased coverage would help with testing '-g admin'.
> 
> Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>
> ---

Good to me,
Reviewed-by: Zorro Lang <zlang@kernel.org>

>  tests/xfs/158 | 2 +-
>  tests/xfs/160 | 2 +-
>  tests/xfs/161 | 2 +-
>  tests/xfs/287 | 2 +-
>  tests/xfs/548 | 2 +-
>  tests/xfs/612 | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/xfs/158 b/tests/xfs/158
> index 89bf8c851659..7b218ec09486 100755
> --- a/tests/xfs/158
> +++ b/tests/xfs/158
> @@ -8,7 +8,7 @@
>  # everything works properly after the upgrade.
>  
>  . ./common/preamble
> -_begin_fstest auto quick inobtcount
> +_begin_fstest auto quick inobtcount admin
>  
>  # Import common functions.
>  . ./common/filter
> diff --git a/tests/xfs/160 b/tests/xfs/160
> index 8cc784e7e1dc..d62b305e4d25 100755
> --- a/tests/xfs/160
> +++ b/tests/xfs/160
> @@ -8,7 +8,7 @@
>  # timestamps work properly after the upgrade.
>  
>  . ./common/preamble
> -_begin_fstest auto quick bigtime
> +_begin_fstest auto quick bigtime admin
>  
>  # Import common functions.
>  . ./common/filter
> diff --git a/tests/xfs/161 b/tests/xfs/161
> index c35bcabb5eda..bcbc2f951f9d 100755
> --- a/tests/xfs/161
> +++ b/tests/xfs/161
> @@ -9,7 +9,7 @@
>  # commit 16b60cb9e315ed for this test to run properly; v4.06 should do.
>  
>  . ./common/preamble
> -_begin_fstest auto quick bigtime quota
> +_begin_fstest auto quick bigtime quota admin
>  
>  # Import common functions.
>  . ./common/filter
> diff --git a/tests/xfs/287 b/tests/xfs/287
> index 4537b040f3cd..d8a1e5379721 100755
> --- a/tests/xfs/287
> +++ b/tests/xfs/287
> @@ -8,7 +8,7 @@
>  # xfs_db functionality
>  #
>  . ./common/preamble
> -_begin_fstest auto dump quota quick
> +_begin_fstest auto dump quota quick admin
>  
>  # Import common functions.
>  . ./common/quota
> diff --git a/tests/xfs/548 b/tests/xfs/548
> index af72885a9c6e..779db614c0e6 100755
> --- a/tests/xfs/548
> +++ b/tests/xfs/548
> @@ -8,7 +8,7 @@
>  # counters.
>  #
>  . ./common/preamble
> -_begin_fstest auto quick metadata
> +_begin_fstest auto quick metadata admin
>  
>  # Import common functions.
>  . ./common/filter
> diff --git a/tests/xfs/612 b/tests/xfs/612
> index 4bead570009a..5fc1d0813ac0 100755
> --- a/tests/xfs/612
> +++ b/tests/xfs/612
> @@ -7,7 +7,7 @@
>  # Check that we can upgrade v5 only features on a v4 file system
>  
>  . ./common/preamble
> -_begin_fstest auto quick
> +_begin_fstest auto quick admin
>  
>  # Import common functions.
>  . ./common/filter
> -- 
> 2.54.0
> 

      reply	other threads:[~2026-11-21 12:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  8:07 [PATCH] xfs: add tests using xfs_admin to the admin group Andrey Albershteyn
2026-11-21 12:27 ` Zorro Lang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=awGOJT8NneMmtluk@zlang-mailbox \
    --to=zlang@kernel.org \
    --cc=aalbersh@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=preichl@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox