From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cn.fujitsu.com ([59.151.112.132]:39304 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751194AbcJTHrC (ORCPT ); Thu, 20 Oct 2016 03:47:02 -0400 From: Qu Wenruo Subject: About reflink len = 0 behavior Message-ID: Date: Thu, 20 Oct 2016 15:46:50 +0800 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: fstests-owner@vger.kernel.org To: "Darrick J. Wong" Cc: fstests@vger.kernel.org, btrfs , xfs@oss.sgi.com List-ID: Hi Darrick, xfs guys and btrfs guys. Although such question is quite late as reflink generic tests are in fstests for a long time, I'm still not sure what's the correct behavior for reflink len = 0. Test case generic/182 is causing different output between btrfs and xfs. For btrfs, dedupe will just return 0 and check nothing, while for xfs len == 0 means to check the whole file length. Both makes sense for me, for btrfs len = 0 behavior, it just follows read/write functions. And I assume xfs follows reflink behavior, when len is not specified, then reflink the length of src file. But since it's a generic test, we need to unify the behavior. So, which one is the standard and which document should we follow for such behavior definition? Thanks, Qu