From: Pankaj Raghav <p.raghav@samsung.com>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: "damien.lemoal@opensource.wdc.com"
<damien.lemoal@opensource.wdc.com>,
"pankydev8@gmail.com" <pankydev8@gmail.com>,
Naohiro Aota <Naohiro.Aota@wdc.com>,
"gost.dev@samsung.com" <gost.dev@samsung.com>,
"mcgrof@kernel.org" <mcgrof@kernel.org>,
"dsterba@suse.cz" <dsterba@suse.cz>,
"fstests@vger.kernel.org" <fstests@vger.kernel.org>,
<boris@bur.io>
Subject: Re: [RFC 0/1] adapting btrfs/237 to work with the new reclaim algorithm
Date: Tue, 13 Dec 2022 14:35:46 +0100 [thread overview]
Message-ID: <c18784f1-4b68-27dd-9042-1a546a4bacea@samsung.com> (raw)
In-Reply-To: <d39c1b29-4489-d998-c503-81449df442a7@wdc.com>
Hi Johannes,
I gave my test a retry, and it started failing for all cases. This commit
by Boris changed the behavior of reclaim to be less aggressive:
https://lore.kernel.org/linux-btrfs/977bdffbf57cca3ee6541efa1563167d4d282b08.1665701210.git.boris@bur.io/
It looks like I need to change the test to cater the current behavior.
The current reclaim algorithm is consistent across all sizes, unlike before.
I will change the test to do the following:
- Write a small file
- Write a big file that crosses the reclaim limit
- Delete the big file
- Check that **only** the block group that contained the small file is
reclaimed, and the small file is relocated to a new block group.
Let me know if the flow of the test case is correct.
On 2022-12-05 17:04, Johannes Thumshirn wrote:
> On 05.12.22 15:53, Pankaj Raghav wrote:
>> Hi Johannes,
>>
>>> Btw, what ever happend to this patch?
>>
>> As I said before, I had trouble reproducing reclaim for 100G drive size,
>> and asked if you could reproduce the same on your end. I did not get any
>> reply to that.
>>
>> I wanted to discuss with you what I was seeing during ALPSS, but we never
>> got around that!
>
> Ah right! I'll try to reproduce it on my end as well.
>
> But even with that one problem it makes the test pass again on my other setups.
>
> So I think it's still an improvement to the status quo. Can you maybe resend it,
> so it's again on Zorro's list?
>
> Thanks,
> Johannes
>
>
next prev parent reply other threads:[~2022-12-13 13:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220819115338eucas1p11b916296213572e97a03241ebdc399d0@eucas1p1.samsung.com>
2022-08-19 11:53 ` [RFC 0/1] adapting btrfs/237 to work with the new reclaim algorithm Pankaj Raghav
2022-08-19 11:53 ` [RFC 1/1] btrfs/237: adapt the test " Pankaj Raghav
2022-08-22 9:40 ` Johannes Thumshirn
2022-08-22 10:49 ` Pankaj Raghav
2022-08-22 12:22 ` Johannes Thumshirn
2022-08-22 14:29 ` [RFC 0/1] adapting btrfs/237 " Johannes Thumshirn
2022-08-23 11:46 ` Pankaj Raghav
2022-12-05 14:53 ` Pankaj Raghav
2022-12-05 16:04 ` Johannes Thumshirn
2022-12-07 16:01 ` Pankaj Raghav
2022-12-13 13:35 ` Pankaj Raghav [this message]
2022-12-05 7:56 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c18784f1-4b68-27dd-9042-1a546a4bacea@samsung.com \
--to=p.raghav@samsung.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=Naohiro.Aota@wdc.com \
--cc=boris@bur.io \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dsterba@suse.cz \
--cc=fstests@vger.kernel.org \
--cc=gost.dev@samsung.com \
--cc=mcgrof@kernel.org \
--cc=pankydev8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox