FS/XFS testing framework
 help / color / mirror / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: [PATCH v2 0/3] fstests: various RAID56 related fixes for btrfs
Date: Fri,  5 Apr 2024 15:56:11 -0400	[thread overview]
Message-ID: <cover.1712346845.git.josef@toxicpanda.com> (raw)

v1: https://lore.kernel.org/linux-btrfs/cover.1710867187.git.josef@toxicpanda.com/

v1->v2:
- Reworked the golden output of btrfs/197 and btrfs/198 to handle running some
  of the RAID profiles.
- Added a new way to require RAID profiles in the tests, updated all the
  different tests.
- Changed btrfs/197, btrfs/198, and btrfs/297 to skip any RAID profiles that
  aren't supported by our RAID profile settings.

--- Original email ---
Hello,

While trying to get CI setup internally I noticed that we were sometimes failing
raid56 tests even though I had specified BTRFS_PROFILE_CONFIGS without raid56 in
them.

This is because tests where we require raid56 to work only check to see if it's
enabled by the kernel, not to check and see if we're configured to use it with
our profile configs.

One test needed to be updated to skip any configurations that weren't in our
profile configs, and then a few tests didn't use the 

_require_btrfs_fs_feature raid56

check in the top of their test.  This series fixes everything up and honors the
user settings which makes my internal CI runs clean where we don't want to test
raid56.  Thanks,

Josef

Josef Bacik (3):
  fstests: change btrfs/197 and btrfs/198 golden output
  fstests: change how we test for supported raid configs
  fstests: update tests to skip unsupported raid profile types

 common/btrfs        | 29 ++++++++++++++++++++++++-----
 tests/btrfs/125     |  2 +-
 tests/btrfs/148     |  3 ++-
 tests/btrfs/157     |  2 +-
 tests/btrfs/158     |  2 +-
 tests/btrfs/197     | 17 +++++++++++++----
 tests/btrfs/197.out | 25 +------------------------
 tests/btrfs/198     | 17 +++++++++++++----
 tests/btrfs/198.out | 25 +------------------------
 tests/btrfs/297     | 10 ++++++++++
 10 files changed, 67 insertions(+), 65 deletions(-)

-- 
2.43.0


             reply	other threads:[~2024-04-05 19:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-05 19:56 Josef Bacik [this message]
2024-04-05 19:56 ` [PATCH v2 1/3] fstests: change btrfs/197 and btrfs/198 golden output Josef Bacik
2024-04-09  1:02   ` Anand Jain
2024-04-05 19:56 ` [PATCH v2 2/3] fstests: change how we test for supported raid configs Josef Bacik
2024-04-09  3:33   ` Anand Jain
2024-04-05 19:56 ` [PATCH v2 3/3] fstests: update tests to skip unsupported raid profile types Josef Bacik
2024-04-09  3:40   ` Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1712346845.git.josef@toxicpanda.com \
    --to=josef@toxicpanda.com \
    --cc=fstests@vger.kernel.org \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox