Re: [PATCH v2 02/13] common/rc: Fix fsx for ext4 with bigalloc

Darrick J. Wong
2025-06-30T15:28:58Z

On Thu, Jun 26, 2025 at 09:32:39AM -0400, Theodore Ts'o wrote:
> On Thu, Jun 26, 2025 at 05:28:53PM +0530, Ojaswin Mujoo wrote:
> > This is achieved by defining a new function _set_default_fsx_avoid
> > called via run_fsx helper. This can be used to selectively disable
> > fsx options based on the configuration.
>
> > +_set_default_fsx_avoid() {
> > + case "$FSTYP" in
> > + "ext4")
> > + if [[ "$MKFS_OPTIONS" =~ bigalloc ]]; then
> > + export FSX_AVOID+=" -I -C"
> > + fi
> > + ;;
>
> This assumes that MKFS_OPTIONS reflects the file system features
> enabled on the file system. That's true by definition for the scratch
> fs, but it's not necessarily true for the test fs. At least in
> theory, someone could run fstests without a scrach device, and then
> MKFS_OPTION?S might not be set.
>
> I'm not sure that we care; is this something that we make assumptions
> in other tests?

/me suspects it ought to be checking dumpe2fs -h output.

--D

>
> - Ted
>