From: Eric Sandeen <sandeen@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "fstests@vger.kernel.org" <fstests@vger.kernel.org>,
Christian Brauner <brauner@kernel.org>
Subject: Re: [PATCH] fix vfs/utils.c for big-endian systems
Date: Fri, 31 Jan 2025 09:36:35 -0600 [thread overview]
Message-ID: <d31161ef-ab18-4963-adee-3a2608282630@redhat.com> (raw)
In-Reply-To: <Z5yFi6Ofr5_I75jL@infradead.org>
On 1/31/25 2:10 AM, Christoph Hellwig wrote:
> On Mon, Jan 27, 2025 at 03:43:24PM -0600, Eric Sandeen wrote:
>> generic/633 was failing with EINVAL on the fsxgetattr call on s390.
>> Looks like this is due to a failure to properly endian swap the
>> arguments to the syscall, so fix that, and the magic_etc compare
>> in expected_dummy_vfs_caps_uid() as well while we're at it.
>
> Looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> Do we need to enable sparse builds for xfstests? Or is this
> goign to create too much churn?
Yeah I wondered about that. I bet adding the infrastructure would be trivial
but the fallout might be a whole other thing. ;)
-Eric
next prev parent reply other threads:[~2025-01-31 15:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 21:43 [PATCH] fix vfs/utils.c for big-endian systems Eric Sandeen
2025-01-27 21:54 ` Darrick J. Wong
2025-01-31 8:10 ` Christoph Hellwig
2025-01-31 15:36 ` Eric Sandeen [this message]
2025-02-04 12:52 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d31161ef-ab18-4963-adee-3a2608282630@redhat.com \
--to=sandeen@redhat.com \
--cc=brauner@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox