From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-187.mta1.migadu.com (out-187.mta1.migadu.com [95.215.58.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11C33435EFA for ; Mon, 13 Jul 2026 13:21:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.187 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783948907; cv=none; b=Otz/c2cbhFIlMAv3iX+73W9lOAPuHqJTYqiCnFwYg+zy708uNDU6mnr/alXjUhLxVK388GWGVXvSe2Q9KXwyEapbJn2aK2huWp91O+2eF9TjamfQzLc9dhv/AOZGAkrHY4rqNCIspTLagx+Ly4+RAjGmg4jeIqLDq0FKFT2Jkog= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783948907; c=relaxed/simple; bh=Y00l/aSmPOJBHXtT2VBY6pzYYLDYF4f40DvYsjUxc28=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=haKYmtnOJOVk5hktYOLS28gHo1hn4KXiZgtBSQqWWDRECRPf7cJef+rBpsi4G2Sl7WSViteOhvo+IYre5p1uKczZafIasS9mRYhsM6Hs0OXqIUsaJZJZKyZjqyGGmwZ/h/rQ4ItYXMpaqQl4yoI1iyWlcTDER/IOtldibgDxjAY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Cov13TH/; arc=none smtp.client-ip=95.215.58.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Cov13TH/" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1783948903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FbcdiqhBJyEUTJK4S+yiy3XNkF/rw3bRMaKqh1gl8bc=; b=Cov13TH/mP0LQyWsxmG9YTHikhR72V4sUNZvXvGhgKIareSiwn1d9oP2yjuoAqBEyrFOov ug9ZU7Bj99oKW48EXUC2NTAV/tnxonGMYfJf5NTl6Ppijqjecq62wFeDeQG8jKkRUWm7ZK Hu8aL9Vd8CapV94IgiiWvkDUX28Yg/Q= Date: Mon, 13 Jul 2026 15:21:36 +0200 Precedence: bulk X-Mailing-List: fstests@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v2] generic/795: add unaligned boundary test cases for WRITE_ZEROES To: Christoph Hellwig , Zhang Yi Cc: Pankaj Raghav , zlang@kernel.org, linux-xfs@vger.kernel.org, fstests@vger.kernel.org, djwong@kernel.org, yi.zhang@huawei.com, Ext4 Developers List References: <20260709083048.3849610-1-p.raghav@samsung.com> <1adabe60-17d5-49ff-a6e6-33f90debf6fe@huaweicloud.com> <20260713100414.GA11013@lst.de> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Pankaj Raghav In-Reply-To: <20260713100414.GA11013@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT >> Unfortunately, I've found a bug in filefrag that causes delalloc extents >> to be reported with a length of 0. This means this test case can miss >> delalloc extents. The issue is in misc/filefrag.c's print_extent_info(), >> where ext_len is incorrectly set to 0 for the FIEMAP_EXTENT_UNKNOWN or >> EXT4_FIEMAP_EXTENT_HOLE cases. Could you please send a patch to fix this >> as well? > > We can't really rely on having a bleeding edge filefrag for xfstests > (well, at least without a feature check for it, but even that > would not a good usability story). I guess at least for now > we might have to add a little tool that just calls FIEMAP for > us to xfstests? > What about adding an option to io/filemap.c to take a flag that allows calling fiemap without FIEMAP_FLAG_SYNC? So this test could depend on xfs_io fiemap command with the flag support enabled? I can revert this test to the previous version which uses xfs io fiemap instead of filefrag. -- Pankaj