From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm0-f51.google.com ([74.125.82.51]:35582 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964873AbdCVQpN (ORCPT ); Wed, 22 Mar 2017 12:45:13 -0400 Received: by mail-wm0-f51.google.com with SMTP id u132so42103097wmg.0 for ; Wed, 22 Mar 2017 09:45:12 -0700 (PDT) Subject: Re: [PATCH v5 2/5] generic/417: Add small copies to new file test References: <20170317195233.4042-1-Anna.Schumaker@Netapp.com> <20170317195233.4042-3-Anna.Schumaker@Netapp.com> From: Boaz Harrosh Message-ID: Date: Wed, 22 Mar 2017 18:45:08 +0200 In-Reply-To: <20170317195233.4042-3-Anna.Schumaker@Netapp.com> Content-Type: text/plain; charset=utf-8 Sender: fstests-owner@vger.kernel.org Content-Transfer-Encoding: Quoted-printable MIME-Version: 1.0 To: Anna Schumaker , fstests@vger.kernel.org Cc: linux-nfs@vger.kernel.org, hch@infradead.org List-ID: On 03/17/2017 09:52 PM, Anna Schumaker wrote: > This test copies single bytes from a source file into various new files > just to make sure that we can handle very small copies. >=20 Sorry for not following closely, but how is this supposed to work, I know t= hat for FSs that support it a copy_file_range is supported by clone_file_range. But usually there are fs-block alignment restrictions on clone_file_range. Does the VFS do the switch from fs->clone to generic-copy, or is the FS suppose to call the generic-copy? Thanks Boaz > Signed-off-by: Anna Schumaker > --- > tests/generic/417 | 83 +++++++++++++++++++++++++++++++++++++++++++++= ++++++ > tests/generic/417.out | 16 ++++++++++ > tests/generic/group | 1 + > 3 files changed, 100 insertions(+) > create mode 100755 tests/generic/417 > create mode 100644 tests/generic/417.out >=20 > diff --git a/tests/generic/417 b/tests/generic/417 > new file mode 100755 > index 00000000..dde3f4d6 > --- /dev/null > +++ b/tests/generic/417 > @@ -0,0 +1,83 @@ > +#!/bin/bash > +# FS QA Test No. 417 > +# > +# Tests vfs_copy_file_range(): > +# - Copy a small file > +# - Small copies from various points in the original file > +#----------------------------------------------------------------------- > +# Copyright (c) 2016 Netapp, Inc. All rights reserved. -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at https://urldefense.proofpoint.com/v2/url?u=3Dhttp-3= A__vger.kernel.org_majordomo-2Dinfo.html&d=3DDwICaQ&c=3DRoP1YumCXCgaWHvlZYR= 8PQcxBKCX5YTpkKY057SbK10&r=3D-yMrTV4jriXR7ieyzzjV-QgHBD0UDw8ixoR77aMeAHE&m= =3Dv6FVYMUNASwMgvV3i2sddVYbdX0ODPC9Fuu8v9kZUHs&s=3DyOpV0LuEKSMkFKKeE9WLbKSs= _cQW9yt6oLHL25DYhHY&e=3D=20