From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2A911C5D5E for ; Tue, 26 May 2026 15:19:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779808776; cv=none; b=AiToerKkU7SUG8wbg0WDXmOkFWp2vGw6b7483hzPyxgg1O6ve1jPtc/tMzgFw+a2XYrYu6VanPsLOMpiNioOjkM2u6j3fbFzFfCpakIDwrziB2nB93T6xS6KkwzpAoTkno93/9MeYzFHI1pfUnNu9rxgOovbasVhjqtwZz7i8vk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779808776; c=relaxed/simple; bh=0ZnjPi7BwnAOrVB91/FYkrKd3xmpByfSExU4BuXXulY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=F4dDR3vtE+JSuWVZnmiq6JPxUknANnnvZ7HrHIns7ncZyUmrOnIznC8a6K3FRBJTdNwBHCrqZndfYwb0nix06iqszDD7vtf2hPU3XUFIYcsQxRLj1J3/v+IRYvreY1O2pBm1gTkf0MnpAZDrz7Nv7oeVljgpeenJQTFr6zIFo2Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dCcHEc51; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dCcHEc51" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-c8173b2af32so8337359a12.0 for ; Tue, 26 May 2026 08:19:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779808774; x=1780413574; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=81JJQRQ2yMbKHbejnSmsG4QSx00hSzBR2QqgEz/z/s4=; b=dCcHEc51DzUejXFJU3CnUz4cmcO4A9DHsnuI2CKbf9ITFWqspVdZziai3B7o9xl5W/ wtkpACv10/WcrV1U5wsAcjg1qYa5cIg8JIHId3hxsDTTtOIWFjlKXajYMY2Jfo2A4qeu 2eZg6r97gA8prwOlR7gY5dsNdL95tdIwk5MjZdc8ePyN/aHTOk1gnsAKgaHNy2g3aHni w5oS4glZ9wgeDKbOpWhBO6sANzc65qoCEG/61ZT6FEXW2qa+uuV4ftz/r5rawMpicFyB 5WGrmaU5KQTPmOgJ5o1uLpEk+j2hTAXIP2a7B8PH0gv1SEDbKpM093lKjKHNKq+fI9ca uu9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779808774; x=1780413574; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=81JJQRQ2yMbKHbejnSmsG4QSx00hSzBR2QqgEz/z/s4=; b=goxZzS53E44f2UFN4lBfrW13Y7mt9TlG344ohhWNU6mlFngWZzJP2V+xd5lAcGHlhf dSXSCuCCcTZXnHjYE/2l4CdiBqH4lA+fvSOA2HWxkGikDbNfyFsF6cVfyCTpUMBIUlwj AmP5iQTSVeiM2FQgR56SOoGLq6ioie++InHeCZdNLyTla/wXaFNoPInCtnA07hVfz4xs HeTy8DNHGx40t/owsvdPl/njaU+QlXEwkFSkKLLBlslXoLDxGR7uHRmlAcF4mVUVijnB c0x8qgWYvp6CTUeVsdaydJ7u/2t7avSXBvtL1fiwiHUs/eoyPAeEX4MNMAefcQ9Ewx88 79xA== X-Forwarded-Encrypted: i=1; AFNElJ+o7e/RtzPVOvN2bbLy2g3i+gWP/m+ASsYNaQTxkzIpb4/Ird/NMxkMaK9IJeMtmNpecDGCJm3B@vger.kernel.org X-Gm-Message-State: AOJu0Yy5TPEr7hepLzJmY8IZd7ZyuwghGGTZ+HP8WgncNG2lMPN72TD9 2YOM6k1LUBCDyoCTwiaVuPszAjOPQcYDv9sM1VF8atC9pBKkfY6YUDZviHruBA== X-Gm-Gg: Acq92OFswnpHS+LEUVLCmG2JorTbRYDzvFqc8KotlG+oAotZ2fWFIuJUB1bLvIqXyQO wfiAzY5wijgIsTDVd/k9j+cusF90fvrPVgFU+Z05RuercB6r2pwPzyyIwVPoTiPyPyo8KP9FIy7 LBP1Vt6Ojn0rSxwLUoKzH62lXDahPCEZHDRKSeAZTVKjwipDimQtCfK0+AopxhybMMAMt+7e89u lvlaWtpYgDEHDZWlXyfNOVhEVPGmoAWwGW/5DlmFt9dU3kIe+TpLxRkpvKxDlSoxCFmPRqB8i6b 1JoNoG9+znjyG59QG03AL1Z6DGdYUAORohlxckN+hwWM6vFTFJZVhCg5IrmPfoyauvxsCSnXo35 qjeprJvihsGcLyKLcyRRVNIy57AhGf73LUAyAnjYqjhc+8iWgYchsLIbtRcLZLFrGCJ+k9yekFs knc8fny/q7pPFKlSt09uoB2P5nYl0= X-Received: by 2002:a05:6a21:68f:b0:3b1:a9ce:5095 with SMTP id adf61e73a8af0-3b328d940ebmr19169216637.22.1779808774114; Tue, 26 May 2026 08:19:34 -0700 (PDT) Received: from [192.168.50.90] ([116.87.14.48]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c8520561e94sm11447223a12.22.2026.05.26.08.19.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 May 2026 08:19:33 -0700 (PDT) Message-ID: Date: Tue, 26 May 2026 23:19:30 +0800 Precedence: bulk X-Mailing-List: fstests@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 03/10] fstests: add test for inotify isolation on cloned devices To: Christoph Hellwig Cc: Anand Jain , fstests@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, amir73il@gmail.com, zlang@redhat.com References: <1c60be06ce79778404079c8b1c1d2e09f64cb38e.1779367627.git.asj@kernel.org> Content-Language: en-US From: Anand Jain In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 26/5/26 14:28, Christoph Hellwig wrote: > On Mon, May 25, 2026 at 04:35:58PM +0800, Anand Jain wrote: >>> Also any reason to rely on the obsolete inotify instead of fsnotify? >> >> fsnotify is exercised in patch 4/10. >> IMO, exercising inotify ensures we don't break legacy stuff. > > fanotity and inotify use exactly the same backends, so I'm not sure > why testing both matters. I noticed that back then I decided to keep both. Since fsnotifywait -F is only supported from kernel 5.1x. inotifywait serves the legacy LTS kernels where required. > Not that I care very strongly, I'm just a > bit confused. I am happy dropping inotifywait if unnecessary and confusing. Thanks.