From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED7D3476066; Thu, 10 Sep 2026 11:48:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789040919; cv=none; b=ijR7kp6gOJVFGb3hri1ayRfsIETFm/Z63AAv9vC1HpphUn842bOL2D5MrFcxhmlqbMCAAn/NJrJ6MPZXWm0dzJx0YrmdlUW6/F3bOvAkjoJ24R/sahG2OAfA45IkUetXJnWsry/Mnpd6aYqvmzpEwbn4cfn749R6C4AycLeH/pQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789040919; c=relaxed/simple; bh=CeaHlpCWLJ2yKz0lH73JkFUe1oJdPEOvnXPlshzH8Ic=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=PJesXG1gBY7CR9PJMWgfdfNoNM0GWO9LfQm4UX6czgdNTxKmTGsiQXdqn6mnV4NCzLwJ5nUwN0eEdvPe13O7LSb/OwmnsOkPlDkElXwhU0F1jyEk5RIzdwRHg8IWmT9sWOfWrPDq2dIqUiJ8nhkpB2RreP3074bomk6gsZ6U6Ao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aOgzenAe; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aOgzenAe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94E411F000FF; Thu, 10 Sep 2026 11:48:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789040917; bh=w/6SaUpGwcR/4xz/rdTBJGbaGTe457lx4yZJNtdCTc0=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=aOgzenAe37aW1u0ymR0Ak0eb4UxS+CUZf3eTXIm2PurJHTjn8hLbOKVGN2yMnRTEu oWURFfjRc3becSe4LBhWcaJwS3Sjv/Hi+40WUx59lF3+3k9lst1SrEMOlfC2GDBJBJ wtfumIUPF/gxKecHXXgcy50VVh9U128VUv9SANHfeA5lkxS7w6Jl3XA0On4aFRXKhJ qY8sysh73d90IGc9I98L52MFteLprVdmI/yaAvcMN3kgJ73YsvmC08kWAaUy2YgvC1 qe9mCuibd1C1gI6ZXZCUHps47LIQow07SMj5dtb5w9wsdppmtH10PG22IC/drsUOuX +we/8Ml5yZpXA== Message-ID: Subject: Re: [RFC PATCH 1/2] common/nfs: add management helpers From: Jeff Layton To: Carlos Maiolino Cc: Christoph Hellwig , "Darrick J. Wong" , zlang@kernel.org, linux-xfs@vger.kernel.org, fstests@vger.kernel.org, jack@suse.cz, Chuck Lever , linux-nfs@vger.kernel.org Date: Thu, 10 Sep 2026 07:48:34 -0400 In-Reply-To: References: <20260907164054.111393-1-cem@kernel.org> <20260907164054.111393-2-cem@kernel.org> <20260908142226.GL839663@frogsfrogsfrogs> <208df4dabcb9db9c6c7d00f4cf2f63fa3be815e1.camel@kernel.org> Autocrypt: addr=jlayton@kernel.org; prefer-encrypt=mutual; keydata=mQINBE6V0TwBEADXhJg7s8wFDwBMEvn0qyhAnzFLTOCHooMZyx7XO7dAiIhDSi7G1NPxw n8jdFUQMCR/GlpozMFlSFiZXiObE7sef9rTtM68ukUyZM4pJ9l0KjQNgDJ6Fr342Htkjxu/kFV1Wv egyjnSsFt7EGoDjdKqr1TS9syJYFjagYtvWk/UfHlW09X+jOh4vYtfX7iYSx/NfqV3W1D7EDi0PqV T2h6v8i8YqsATFPwO4nuiTmL6I40ZofxVd+9wdRI4Db8yUNA4ZSP2nqLcLtFjClYRBoJvRWvsv4lm 0OX6MYPtv76hka8lW4mnRmZqqx3UtfHX/hF/zH24Gj7A6sYKYLCU3YrI2Ogiu7/ksKcl7goQjpvtV YrOOI5VGLHge0awt7bhMCTM9KAfPc+xL/ZxAMVWd3NCk5SamL2cE99UWgtvNOIYU8m6EjTLhsj8sn VluJH0/RcxEeFbnSaswVChNSGa7mXJrTR22lRL6ZPjdMgS2Km90haWPRc8Wolcz07Y2se0xpGVLEQ cDEsvv5IMmeMe1/qLZ6NaVkNuL3WOXvxaVT9USW1+/SGipO2IpKJjeDZfehlB/kpfF24+RrK+seQf CBYyUE8QJpvTZyfUHNYldXlrjO6n5MdOempLqWpfOmcGkwnyNRBR46g/jf8KnPRwXs509yAqDB6sE LZH+yWr9LQZEwARAQABtCVKZWZmIExheXRvbiA8amxheXRvbkBwb29jaGllcmVkcy5uZXQ+iQI7BB MBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUCTpXWPAIZAQAKCRAADmhBGVaCFc65D/4 gBLNMHopQYgG/9RIM3kgFCCQV0pLv0hcg1cjr+bPI5f1PzJoOVi9s0wBDHwp8+vtHgYhM54yt43uI 7Htij0RHFL5eFqoVT4TSfAg2qlvNemJEOY0e4daljjmZM7UtmpGs9NN0r9r50W82eb5Kw5bc/r0km R/arUS2st+ecRsCnwAOj6HiURwIgfDMHGPtSkoPpu3DDp/cjcYUg3HaOJuTjtGHFH963B+f+hyQ2B rQZBBE76ErgTDJ2Db9Ey0kw7VEZ4I2nnVUY9B5dE2pJFVO5HJBMp30fUGKvwaKqYCU2iAKxdmJXRI ONb7dSde8LqZahuunPDMZyMA5+mkQl7kpIpR6kVDIiqmxzRuPeiMP7O2FCUlS2DnJnRVrHmCljLkZ Wf7ZUA22wJpepBligemtSRSbqCyZ3B48zJ8g5B8xLEntPo/NknSJaYRvfEQqGxgk5kkNWMIMDkfQO lDSXZvoxqU9wFH/9jTv1/6p8dHeGM0BsbBLMqQaqnWiVt5mG92E1zkOW69LnoozE6Le+12DsNW7Rj iR5K+27MObjXEYIW7FIvNN/TQ6U1EOsdxwB8o//Yfc3p2QqPr5uS93SDDan5ehH59BnHpguTc27Xi QQZ9EGiieCUx6Zh2ze3X2UW9YNzE15uKwkkuEIj60NvQRmEDfweYfOfPVOueC+iFifbQgSmVmZiBM YXl0b24gPGpsYXl0b25AcmVkaGF0LmNvbT6JAjgEEwECACIFAk6V0q0CGwMGCwkIBwMCBhUIAgkKC wQWAgMBAh4BAheAAAoJEAAOaEEZVoIViKUQALpvsacTMWWOd7SlPFzIYy2/fjvKlfB/Xs4YdNcf9q LqF+lk2RBUHdR/dGwZpvw/OLmnZ8TryDo2zXVJNWEEUFNc7wQpl3i78r6UU/GUY/RQmOgPhs3epQC 3PMJj4xFx+VuVcf/MXgDDdBUHaCTT793hyBeDbQuciARDJAW24Q1RCmjcwWIV/pgrlFa4lAXsmhoa c8UPc82Ijrs6ivlTweFf16VBc4nSLX5FB3ls7S5noRhm5/Zsd4PGPgIHgCZcPgkAnU1S/A/rSqf3F LpU+CbVBDvlVAnOq9gfNF+QiTlOHdZVIe4gEYAU3CUjbleywQqV02BKxPVM0C5/oVjMVx3bri75n1 TkBYGmqAXy9usCkHIsG5CBHmphv9MHmqMZQVsxvCzfnI5IO1+7MoloeeW/lxuyd0pU88dZsV/riHw 87i2GJUJtVlMl5IGBNFpqoNUoqmvRfEMeXhy/kUX4Xc03I1coZIgmwLmCSXwx9MaCPFzV/dOOrju2 xjO+2sYyB5BNtxRqUEyXglpujFZqJxxau7E0eXoYgoY9gtFGsspzFkVNntamVXEWVVgzJJr/EWW0y +jNd54MfPRqH+eCGuqlnNLktSAVz1MvVRY1dxUltSlDZT7P2bUoMorIPu8p7ZCg9dyX1+9T6Muc5d Hxf/BBP/ir+3e8JTFQBFOiLNdFtB9KZWZmIExheXRvbiA8amxheXRvbkBzYW1iYS5vcmc+iQI4BBM BAgAiBQJOldK9AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRAADmhBGVaCFWgWD/0ZRi4h N9FK2BdQs9RwNnFZUr7JidAWfCrs37XrA/56olQl3ojn0fQtrP4DbTmCuh0SfMijB24psy1GnkPep naQ6VRf7Dxg/Y8muZELSOtsv2CKt3/02J1BBitrkkqmHyni5fLLYYg6fub0T/8Kwo1qGPdu1hx2BQ RERYtQ/S5d/T0cACdlzi6w8rs5f09hU9Tu4qV1JLKmBTgUWKN969HPRkxiojLQziHVyM/weR5Reu6 FZVNuVBGqBD+sfk/c98VJHjsQhYJijcsmgMb1NohAzwrBKcSGKOWJToGEO/1RkIN8tqGnYNp2G+aR 685D0chgTl1WzPRM6mFG1+n2b2RR95DxumKVpwBwdLPoCkI24JkeDJ7lXSe3uFWISstFGt0HL8Eew P8RuGC8s5h7Ct91HMNQTbjgA+Vi1foWUVXpEintAKgoywaIDlJfTZIl6Ew8ETN/7DLy8bXYgq0Xzh aKg3CnOUuGQV5/nl4OAX/3jocT5Cz/OtAiNYj5mLPeL5z2ZszjoCAH6caqsF2oLyAnLqRgDgR+wTQ T6gMhr2IRsl+cp8gPHBwQ4uZMb+X00c/Amm9VfviT+BI7B66cnC7Zv6Gvmtu2rEjWDGWPqUgccB7h dMKnKDthkA227/82tYoFiFMb/NwtgGrn5n2vwJyKN6SEoygGrNt0SI84y6hEVbQlSmVmZiBMYXl0b 24gPGpsYXl0b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmKQIbAwcLCQgHAwIBBhUIAg kKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIV1H0P/j4OUTwFd7BBbpoSp695qb6HqCzWMuExsp8nZjr uymMaeZbGr3OWMNEXRI1FWNHMtcMHWLP/RaDqCJil28proO+PQ/yPhsr2QqJcW4nr91tBrv/MqItu AXLYlsgXqp4BxLP67bzRJ1Bd2x0bWXurpEXY//VBOLnODqThGEcL7jouwjmnRh9FTKZfBDpFRaEfD FOXIfAkMKBa/c9TQwRpx2DPsl3eFWVCNuNGKeGsirLqCxUg5kWTxEorROppz9oU4HPicL6rRH22Ce 6nOAON2vHvhkUuO3GbffhrcsPD4DaYup4ic+DxWm+DaSSRJ+e1yJvwi6NmQ9P9UAuLG93S2MdNNbo sZ9P8k2mTOVKMc+GooI9Ve/vH8unwitwo7ORMVXhJeU6Q0X7zf3SjwDq2lBhn1DSuTsn2DbsNTiDv qrAaCvbsTsw+SZRwF85eG67eAwouYk+dnKmp1q57LDKMyzysij2oDKbcBlwB/TeX16p8+LxECv51a sjS9TInnipssssUDrHIvoTTXWcz7Y5wIngxDFwT8rPY3EggzLGfK5Zx2Q5S/N0FfmADmKknG/D8qG IcJE574D956tiUDKN4I+/g125ORR1v7bP+OIaayAvq17RP+qcAqkxc0x8iCYVCYDouDyNvWPGRhbL UO7mlBpjW9jK9e2fvZY9iw3QzIPGKtClKZWZmIExheXRvbiA8amVmZi5sYXl0b25AcHJpbWFyeWRh dGEuY29tPokCOQQTAQIAIwUCU4xmUAIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOa EEZVoIVzJoQALFCS6n/FHQS+hIzHIb56JbokhK0AFqoLVzLKzrnaeXhE5isWcVg0eoV2oTScIwUSU apy94if69tnUo4Q7YNt8/6yFM6hwZAxFjOXR0ciGE3Q+Z1zi49Ox51yjGMQGxlakV9ep4sV/d5a50 M+LFTmYSAFp6HY23JN9PkjVJC4PUv5DYRbOZ6Y1+TfXKBAewMVqtwT1Y+LPlfmI8dbbbuUX/kKZ5d dhV2736fgyfpslvJKYl0YifUOVy4D1G/oSycyHkJG78OvX4JKcf2kKzVvg7/Rnv+AueCfFQ6nGwPn 0P91I7TEOC4XfZ6a1K3uTp4fPPs1Wn75X7K8lzJP/p8lme40uqwAyBjk+IA5VGd+CVRiyJTpGZwA0 jwSYLyXboX+Dqm9pSYzmC9+/AE7lIgpWj+3iNisp1SWtHc4pdtQ5EU2SEz8yKvDbD0lNDbv4ljI7e flPsvN6vOrxz24mCliEco5DwhpaaSnzWnbAPXhQDWb/lUgs/JNk8dtwmvWnqCwRqElMLVisAbJmC0 BhZ/Ab4sph3EaiZfdXKhiQqSGdK4La3OTJOJYZphPdGgnkvDV9Pl1QZ0ijXQrVIy3zd6VCNaKYq7B AKidn5g/2Q8oio9Tf4XfdZ9dtwcB+bwDJFgvvDYaZ5bI3ln4V3EyW5i2NfXazz/GA/I/ZtbsigCFc 8ftCBKZWZmIExheXRvbiA8amxheXRvbkBrZXJuZWwub3JnPokCOAQTAQIAIgUCWe8u6AIbAwYLCQg HAwIGFQgCCQoLBBYCAwECHgECF4AACgkQAA5oQRlWghUuCg/+Lb/xGxZD2Q1oJVAE37uW308UpVSD 2tAMJUvFTdDbfe3zKlPDTuVsyNsALBGclPLagJ5ZTP+Vp2irAN9uwBuacBOTtmOdz4ZN2tdvNgozz uxp4CHBDVzAslUi2idy+xpsp47DWPxYFIRP3M8QG/aNW052LaPc0cedYxp8+9eiVUNpxF4SiU4i9J DfX/sn9XcfoVZIxMpCRE750zvJvcCUz9HojsrMQ1NFc7MFT1z3MOW2/RlzPcog7xvR5ENPH19ojRD CHqumUHRry+RF0lH00clzX/W8OrQJZtoBPXv9ahka/Vp7kEulcBJr1cH5Wz/WprhsIM7U9pse1f1g Yy9YbXtWctUz8uvDR7shsQxAhX3qO7DilMtuGo1v97I/Kx4gXQ52syh/w6EBny71CZrOgD6kJwPVV AaM1LRC28muq91WCFhs/nzHozpbzcheyGtMUI2Ao4K6mnY+3zIuXPygZMFr9KXE6fF7HzKxKuZMJO aEZCiDOq0anx6FmOzs5E6Jqdpo/mtI8beK+BE7Va6ni7YrQlnT0i3vaTVMTiCThbqsB20VrbMjlhp f8lfK1XVNbRq/R7GZ9zHESlsa35ha60yd/j3pu5hT2xyy8krV8vGhHvnJ1XRMJBAB/UYb6FyC7S+m QZIQXVeAA+smfTT0tDrisj1U5x6ZB9b3nBg65kc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.2 (3.60.2-1.fc44) Precedence: bulk X-Mailing-List: fstests@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2026-09-10 at 13:40 +0200, Carlos Maiolino wrote: > On Thu, Sep 10, 2026 at 07:30:46AM -0400, Jeff Layton wrote: > > On Tue, 2026-09-08 at 23:12 -0700, Christoph Hellwig wrote: > > > On Tue, Sep 08, 2026 at 07:22:26AM -0700, Darrick J. Wong wrote: > > > > > +# Start rpcbind if it is not already running. > > > > > +_start_rpcbind() > > > > > +{ > > > > > + rpcinfo -p localhost > /dev/null 2>&1 && return 0 > > > > > + rpcbind 2>> $seqres.full || _notrun "Cannot start rpcbind" > > > > > + /usr/sbin/rpc.statd 2>> $seqres.full || _notrun "Cannot start r= pc.statd" > > > > > + /usr/sbin/rpc.idmapd 2>> $seqres.full || _notrun "Cannot start = rpc.idmapd" > > > > > + /usr/sbin/nfsdcld 2>> $seqres.full || _notrun "Cannot start nfs= dcld" > > > >=20 > > > > Aren't these daemons usually configured as system services? > > > >=20 > > > > # service rpcbind start > > > >=20 > > > > etc? > > >=20 > > > They usually are, but doing that as part of a test feels wrong. > > > Adding the relevant maintainers and list. > > >=20 > > >=20 > >=20 > > I don't see a problem with using the normal systemd services as long as > > you're just doing a "start" instead of an "enable". That would be a lot > > less likely to bitrot than these scripts. >=20 > My only concern regarding using systemd services is portability. I tried > to keep the test agnostic to the init system being used, but it indeed > would be way easier to put this into xfstests if we just accept this > will be a __not_run on systemd-less distros. Giving the majority of > people I know frequently running xfstests (including me) uses > systemd-based distros, this wouldn't be a problem for me personally... >=20 That's what I'd probably do. If someone wants to step up and do something for non-systemd distros then they can have at it. Alternately, you could use systemd and just fall back to what you're doing now in the case where it's not present. My only fear there is that the non-systemd cases would probably bitrot because no one would use them. That said, if you're doing all of this in a container then it shouldn't matter much how it gets started. > >=20 > > > > > +} > > > > > + > > > > > +# Stop rpcbind. > > > > > +_stop_rpcbind() > > > > > +{ > > > > > + pkill rpcbind 2>/dev/null > > > > > +} > > > > > + > > > > > +# Start the NFS server if not already running. > > > > > +_start_nfsd() > > > > > +{ > > > > > + rpcinfo -p localhost 2>/dev/null | grep -q nfs && return 0 > > > > > + rpc.nfsd 2>> $seqres.full || _notrun "Cannot start rpc.nfsd" If you do decide to go this route, note that rpc.nfsd is being deprecated. We have a new tool for managing the server now called "nfsdctl" that you probably want to use when possible. > > > > > + rpc.mountd 2>> $seqres.full || _notrun "Cannot start rpc.mountd= " > > > > > +} > > > > > + > > > > > +# Stop the NFS server. > > > > > +_stop_nfsd() > > > > > +{ > > > > > + rpc.nfsd 0 2>/dev/null > > > > > + pkill rpc.mountd 2>/dev/null > > > >=20 > > > > If the system under test has nfs filesystems mounted, won't killing > > > > those daemons also break the mounts? > > > >=20 > > > > I think that might break testing of nfs itself, and nfs-booted test= ing > > > > nodes as well? > > >=20 > > > Possibly. I guess if we want to save we need to launch a container > > > or at least a network namespace this is bound too.=20 > >=20 > > Doing this in a container would be better and less likely to interfere > > with other stuff running on the box. Our container isolation is still > > not 100% perfect with nfsd (there is still a global mutex, etc.), but > > we're getting closer. > >=20 > > --=20 > > Jeff Layton > >=20 --=20 Jeff Layton