FS/XFS testing framework
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: fstests@vger.kernel.org
Cc: linux-btrfs@vger.kernel.org, zlang@redhat.com, djwong@kernel.org
Subject: [PATCH 1/2] fstests: remove duplicate initialization in the testcase
Date: Sat, 24 May 2025 11:57:13 +0800	[thread overview]
Message-ID: <ef4d2dbb8d82020bc3eac655d03650bfbd77f9ff.1748058175.git.anand.jain@oracle.com> (raw)
In-Reply-To: <cover.1748058175.git.anand.jain@oracle.com>

_begin_fstest() already initializes several variables, including `seq` and
`seqres`, so remove those redundant initializations from the testcase.

Also, ext4/053 unnecessarily re-initializes `here`, `tmp`, and `status`,
which `_begin_fstest` already handles. Remove those as well.

and remove template comment.

Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
 tests/btrfs/253 |  3 ---
 tests/ext4/053  | 10 ----------
 2 files changed, 13 deletions(-)

diff --git a/tests/btrfs/253 b/tests/btrfs/253
index 96ab140f1780..a0cc9b55de69 100755
--- a/tests/btrfs/253
+++ b/tests/btrfs/253
@@ -28,9 +28,6 @@
 . ./common/sysfs
 _begin_fstest auto
 
-seq=`basename $0`
-seqres="${RESULT_DIR}/${seq}"
-
 # Parse a size string which is in the format "XX.XXMib".
 #
 # Parameters:
diff --git a/tests/ext4/053 b/tests/ext4/053
index 77b3ac8171f0..55f337b48355 100755
--- a/tests/ext4/053
+++ b/tests/ext4/053
@@ -9,12 +9,6 @@
 . ./common/preamble
 _begin_fstest auto mount
 
-seq=`basename $0`
-seqres=$RESULT_DIR/$seq
-
-here=`pwd`
-tmp=/tmp/$$
-status=1	# failure is the default!
 trap "_cleanup; exit \$status" 0 1 2 3 15
 
 _cleanup()
@@ -27,13 +21,9 @@ _cleanup()
 	rm -f $tmp.*
 }
 
-# get standard environment, filters and checks
 . ./common/filter
 . ./common/quota
 
-# remove previous $seqres.full before test
-rm -f $seqres.full
-
 echo "Silence is golden."
 
 SIZE=$((1024 * 1024))	# 1GB in KB
-- 
2.49.0


  reply	other threads:[~2025-05-24  3:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-24  3:57 [PATCH 0/2] fstests: cleanup duplicate initialization and avoid writing to .full Anand Jain
2025-05-24  3:57 ` Anand Jain [this message]
2025-07-01 14:15   ` [PATCH 1/2] fstests: remove duplicate initialization in the testcase Zorro Lang
2025-05-24  3:57 ` [PATCH 2/2] fstests: check: fix unset seqres in run_section() Anand Jain
2025-07-01 14:28   ` Zorro Lang
2025-07-01 10:02 ` [PATCH 0/2] fstests: cleanup duplicate initialization and avoid writing to .full Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ef4d2dbb8d82020bc3eac655d03650bfbd77f9ff.1748058175.git.anand.jain@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox