FS/XFS testing framework
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: "fstests@vger.kernel.org" <fstests@vger.kernel.org>,
	Namjae Jeon <linkinjeon@kernel.org>
Subject: Re: [PATCH] generic: test zero-byte writes to new file
Date: Thu, 13 Feb 2025 21:17:28 -0600	[thread overview]
Message-ID: <f05f9875-1552-4d77-8403-7b191da24141@redhat.com> (raw)
In-Reply-To: <e2240afa-2335-4462-81db-410d0b10737f@redhat.com>

On 2/13/25 2:50 PM, Eric Sandeen wrote:
> On 2/13/25 1:51 PM, Darrick J. Wong wrote:

...

>>> +rm -f $TEST_DIR/testfile.$seq
>>> +$XFS_IO_PROG -f -c "pwrite 0 0" $TEST_DIR/testfile.$seq
>>> +test -f $TEST_DIR/testfile.$seq || _fail "file not created"
>>
>> When does the file not get created?
> 
> In some unknown error case? ;)
> There's probably no reason for that test, though of course
> it's still expected to pass.
> 
> In the various discussions of the exfat bug scattered around
> the internet people kept pointing out that "well, the file does
> get created" so I probably had that on my mind.

To put a finer point on it, because I can't tell for sure - are
you asking me to take that test out?

Thanks,
-Eric


  reply	other threads:[~2025-02-14  3:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-13 18:06 [PATCH] generic: test zero-byte writes to new file Eric Sandeen
2025-02-13 19:51 ` Darrick J. Wong
2025-02-13 20:50   ` Eric Sandeen
2025-02-14  3:17     ` Eric Sandeen [this message]
2025-02-14  4:02       ` Darrick J. Wong
2025-02-14  5:46         ` Namjae Jeon
2025-02-14 14:36         ` Eric Sandeen
2025-02-18 17:39           ` Darrick J. Wong
2025-02-21 16:07             ` Eric Sandeen
2025-02-21  5:14 ` Nirjhar Roy (IBM)
2025-02-21 16:47   ` Darrick J. Wong
2025-02-24  4:39     ` Nirjhar Roy (IBM)
2025-02-25 22:29     ` Eric Sandeen
2025-02-26 10:57       ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f05f9875-1552-4d77-8403-7b191da24141@redhat.com \
    --to=sandeen@redhat.com \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=linkinjeon@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox