Re: [PATCH] generic/471: Remove this broken case

[Jens Axboe <axboe@kernel.dk>]

On 8/14/23 9:37 AM, Darrick J. Wong wrote:
> On Mon, Aug 14, 2023 at 10:41:41PM +0800, Yang Xu wrote:
>> I remember this case fails on last year becuase of
>> kernel commit cae2de69 ("iomap: Add async buffered write support")
>> kernel commit 1aa91d9 ("xfs: Add async buffered write support").
>> as below:
>>      pwrite: Resource temporarily unavailable
>>      wrote 8388608/8388608 bytes at offset 0
>>      XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
>>     -RWF_NOWAIT time is within limits.
>>     +pwrite: Resource temporarily unavailable
>>     +(standard_in) 1: syntax error
>>     +RWF_NOWAIT took  seconds
>>
>> So For async buffered write requests, the request will return -EAGAIN
>> if the ilock cannot be obtained immediately.
>>
>> Here also a discussion[1] that seems generic/471 has been broken.
>>
>> Now, I met this problem in my linux distribution, then I found the above
>> discussion. IMO, remove this case is ok and then we can avoid to meet this
>> false report again.
>>
>> [1]https://lore.kernel.org/linux-xfs/b2865bd6-2346-8f4d-168b-17f06bbedbed@kernel.dk/
>> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> 
> Fine with me, since nobody thinks this test does anything useful, nor
> has anyone made it do something useful.

It has never done anything useful, it's a test that was added so that
someone could say they had a test case for a kernel change that they
made. Killing it is the right choice, as I've argued for before.

Reviewed-by: Jens Axboe <axboe@kernel.dk>

-- 
Jens Axboe