From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C99313DA7DD for ; Thu, 21 May 2026 13:10:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779369042; cv=none; b=aK+OdDfthXAv1mMKEwokdNvutUM2aYhkpO/eMiJO7gtNXuX4zpnn2m348+Qll81Ur/qd08iu3Prcnj2E4TnO0/hQRduO/KvqpW5cfItLvMwTH0C03iH+55VRDblVh0fZDLIhwM51nctIRD8WDT5SOYl9p2ukfbkM6YnOfVQSBKA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779369042; c=relaxed/simple; bh=jX4JZvwPm/rEPVJFzf/ejOA6DjYxYRHfgyp4VE85mTY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IqLyEdAcNoYx3d5PmLy7PO5SbppqKJfre9EdDcCXm7EHc+GFK7Nkrek/erS0B6AlqvHBlS4ojbs/l4hLna+jicz85wHjI36SXUb4NryO/3qorElb0Mqcju4FbWO0rSA1B87FdmMadXErs+hCxWeeYCaZJO4rrK1OfOliXhx+d1g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L0gHfgbZ; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L0gHfgbZ" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-838d0b7c950so4330990b3a.3 for ; Thu, 21 May 2026 06:10:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779369040; x=1779973840; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=G4yDEmmytiLp8y/IlWHiohedbGrR4sjKi+TCYvwlxxo=; b=L0gHfgbZ0lNXv8VzDT6T4RAlAMMWK8/8f3ZL92OEZALzVmq/w9h6nmxqTJ/EXHFFU6 XUCxt0pAYX415Neyr3ZBVTEqiscISanap1vHo71qbPqOWFTBiWkoO7zMCXWWTO0wMGM+ M5bTpa76oM3uLO3HBpSU/MllwaKcEAW9u4Ew+EX0obHRBIx8ajJntiH3Gfdg+pbu7AC8 q9xtkKx3wSdZE1kuLkl2hzMH46FgDCNSAsFRbbAJNrIgtElZMmHHRbjrXcM0q7eoJbAm CjZFLoU+0UnEZnWfu1/qArHmJz6L5lwIlWpbNH7kTFkJoEj0fz8U3Vt2dBFOzmBJomIr Z5fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779369040; x=1779973840; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=G4yDEmmytiLp8y/IlWHiohedbGrR4sjKi+TCYvwlxxo=; b=dBSPCO4BljaikgLk0SXm9bqooCzxGNmYtKXQnQbk4/UXI5eEgcQtU15ddaW8vRjDAY B+mMlXdAK+Dl7US1C5lSvKNcxHy4S3f1ZFZUSupPrqArOhaezwAXogApH1se9+F8ZKH5 GMNEpPRwzRunYa8s3ywmVmGEKo0lZe/1jEywLOBkw2NQxDD4iJNmZwSW6ot8uMagV1NW Kazl/8qd00fCqx0WvMbSuWmwwpzP3fBxTR+czAT4aJ11p1MHMe6h/eUvWjnhB3u5Y0kx uV4f36rnn9MQh5sW46ITOhGxnq7LSOhUjI1RM/XgZE3RDIui/hIy5nZzgY1imU1ytcg5 BYcg== X-Gm-Message-State: AOJu0Yz5hcI9dLQ7k+df/ryd+V5j+liPVDXR93Ifo/5/E2Up/SUyV5qq J7UhmvWc0sPIYrisO2bFSuoR5u9txnH1Bl/jBFOoR29QcNtNC23TQAmgcADYqg== X-Gm-Gg: Acq92OFmklrYjGRVzoznJEjnBN6ttl+b/p6igYx4n2wlz4o2JLHpLNL9A1/B4UMjh5B y0MsWRG9ksDiZ2moBicNKCLYc8O7Ms64wBsbXElqxzUbq0b3VdmdORgZAfV/PoeZlFW4ww/VtO0 3Nkl4Dkpcfx8TQZHw9Agcu8LnbFiFRXowtDvY3IujURzpNBv+w3OrIb/fcZaiyaM1TLbe0dv4ac 9XibFUiN4uMJo/WOEBu/zimCZlP1TUbFPth92LtaraxfcmgmAEyJ2OG/IXXMubDmW+mzgLSTLtJ DI1gI6VXWccvlcX/863eemM6/YQosfv2hl8OB60BTVk1SY+BW1aJe8ISKE/+zmG4w8THF0CVkLV 5FC2rCJB3ZjDBVYHLoSXU0juB3fF28pARJKHz+70j9AQB3beC7EHKl8VF0xOAW9a/i0osxfAXIx GF0ZW2n2VIW/qW1YmZAMdcIRBPRLI= X-Received: by 2002:a05:6a00:228e:b0:835:6d99:3f88 with SMTP id d2e1a72fcca58-8414adf3933mr3055752b3a.23.1779369040007; Thu, 21 May 2026 06:10:40 -0700 (PDT) Received: from [192.168.50.90] ([116.87.14.48]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84154a010d3sm1319228b3a.18.2026.05.21.06.10.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 May 2026 06:10:39 -0700 (PDT) Message-ID: Date: Thu, 21 May 2026 21:10:36 +0800 Precedence: bulk X-Mailing-List: fstests@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 09/10] fstests: add pre_clone_tune_uuid() healper To: fstests@vger.kernel.org, zlang@redhat.com, Zorro Lang Cc: linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-f2fs@vger.kernel.org, amir73il@gmail.com, hch@infradead.org, Anand Jain References: <0d9f455d20145103faaf4e45262ee44418cbaca1.1779367627.git.asj@kernel.org> Content-Language: en-US From: Anand Jain In-Reply-To: <0d9f455d20145103faaf4e45262ee44418cbaca1.1779367627.git.asj@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 21/5/26 20:54, Anand Jain wrote: > pre_clone_tune_uuid() changes the UUID of the golden filesystem before it > is cloned. > > Signed-off-by: Anand Jain > --- > common/rc | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/common/rc b/common/rc > index 7ae9877918c8..1b3a32d9ea9b 100644 > --- a/common/rc > +++ b/common/rc > @@ -1517,6 +1517,26 @@ _scratch_resvblks() > esac > } > > +pre_clone_tune_uuid() I missed the "_" prefix for pre_clone_tune_uuid() to match the common/rc style. Zorro, If there are no other rerolls, can you please fix it at merge or should I resend? Thanks > +{ > + local temp_mnt=$TEST_DIR/${seq}_mnt > + local dev=$1 > + > + case $FSTYP in > + xfs) > + _require_command "$XFS_ADMIN_PROG" "xfs_admin" > + $XFS_ADMIN_PROG -U generate $dev >> $seqres.full > + ;; > + btrfs) > + _require_command "$BTRFS_TUNE_PROG" "btrfstune" > + $BTRFS_TUNE_PROG -m $dev > + ;; > + *) > + _notrun "Require filesystem with metadata_uuid feature" > + ;; > + esac > +} > + > _loop_image_create_clone() > { > local -n _ret=$1