From: John Garry <john.g.garry@oracle.com>
To: Catherine Hoang <catherine.hoang@oracle.com>,
linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Cc: djwong@kernel.org, ritesh.list@gmail.com, ojaswin@linux.ibm.com
Subject: Re: [PATCH v3 2/3] generic: various atomic write tests with scsi_debug
Date: Thu, 5 Jun 2025 16:27:14 +0100 [thread overview]
Message-ID: <fc587ef0-bd8b-4336-8425-547fc9d1695b@oracle.com> (raw)
In-Reply-To: <20250605040122.63131-3-catherine.hoang@oracle.com>
On 05/06/2025 05:01, Catherine Hoang wrote:
> Simple tests of various atomic write requests and a (simulated) hardware
> device.
There's > 400 lines of changes, and a one sentence changelog.
>
> Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
> Signed-off-by: Catherine Hoang <catherine.hoang@oracle.com>
An odd Signed-off-by chain.
> ---
> common/atomicwrites | 10 ++++
> tests/generic/1222 | 89 ++++++++++++++++++++++++++++
> tests/generic/1222.out | 10 ++++
> tests/generic/1223 | 67 +++++++++++++++++++++
> tests/generic/1223.out | 9 +++
> tests/generic/1224 | 86 +++++++++++++++++++++++++++
> tests/generic/1224.out | 16 ++++++
> tests/generic/1225 | 128 +++++++++++++++++++++++++++++++++++++++++
> tests/generic/1225.out | 21 +++++++
> 9 files changed, 436 insertions(+)
> create mode 100755 tests/generic/1222
> create mode 100644 tests/generic/1222.out
> create mode 100755 tests/generic/1223
> create mode 100644 tests/generic/1223.out
> create mode 100755 tests/generic/1224
> create mode 100644 tests/generic/1224.out
> create mode 100755 tests/generic/1225
> create mode 100644 tests/generic/1225.out
This all looks ok, I would suggest a separate patch per test and I don't
feel strongly about that
Thanks,
John
next prev parent reply other threads:[~2025-06-05 15:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 4:01 [PATCH v3 0/3] atomic writes tests (part 2) Catherine Hoang
2025-06-05 4:01 ` [PATCH v3 1/3] common/atomicwrites: add helper for multi block atomic writes Catherine Hoang
2025-06-05 15:20 ` John Garry
2025-06-09 4:23 ` Ritesh Harjani
2025-06-05 4:01 ` [PATCH v3 2/3] generic: various atomic write tests with scsi_debug Catherine Hoang
2025-06-05 15:27 ` John Garry [this message]
2025-06-05 4:01 ` [PATCH v3 3/3] xfs: more multi-block atomic writes tests Catherine Hoang
2025-06-05 15:29 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc587ef0-bd8b-4336-8425-547fc9d1695b@oracle.com \
--to=john.g.garry@oracle.com \
--cc=catherine.hoang@oracle.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox