From: Jeff Moyer <jmoyer@redhat.com>
To: fstests@vger.kernel.org
Subject: [patch] xfs/259 - inherit $_fs_has_crcs
Date: Fri, 04 Dec 2015 10:41:48 -0500 [thread overview]
Message-ID: <x494mfy5igz.fsf@segfault.boston.devel.redhat.com> (raw)
Hi,
When running xfs/259 against a file system that has crcs disabled, the
test will fail. The problem is that mkfs.xfs now defaults to enabling
crcs. So, when the test checks the underlying file system and finds
crcs are disabled, it tries to create a file system with a block size
that is too small to support them. The solution is to explicitly
specify the crc feature.
Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
diff --git a/tests/xfs/259 b/tests/xfs/259
index 16c1935..e0022ce 100755
--- a/tests/xfs/259
+++ b/tests/xfs/259
@@ -72,7 +72,7 @@ for del in $sizes_to_check; do
lofile=$(losetup -f)
losetup $lofile "$testfile"
"$MKFS_XFS_PROG" -l size=32m -b size=$blocksize $lofile \
- >/dev/null || echo "mkfs failed!"
+ -m crc=$_fs_has_crcs>/dev/null || echo "mkfs failed!"
sync
losetup -d $lofile
done
next reply other threads:[~2015-12-04 15:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 15:41 Jeff Moyer [this message]
2015-12-04 15:47 ` [patch] xfs/259 - inherit $_fs_has_crcs Jeff Moyer
2015-12-04 20:45 ` Brian Foster
2015-12-04 20:56 ` Jeff Moyer
2015-12-05 8:09 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x494mfy5igz.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox