From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.redhat.com ([209.132.183.28]:44372 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753309AbbLDPrs (ORCPT ); Fri, 4 Dec 2015 10:47:48 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 9FC6DC0A804D for ; Fri, 4 Dec 2015 15:47:48 +0000 (UTC) Received: from segfault.boston.devel.redhat.com (segfault.boston.devel.redhat.com [10.19.60.26]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tB4FllaW007961 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Fri, 4 Dec 2015 10:47:48 -0500 From: Jeff Moyer Subject: Re: [patch] xfs/259 - inherit $_fs_has_crcs References: Date: Fri, 04 Dec 2015 10:47:47 -0500 In-Reply-To: (Jeff Moyer's message of "Fri, 04 Dec 2015 10:41:48 -0500") Message-ID: MIME-Version: 1.0 Content-Type: text/plain Sender: fstests-owner@vger.kernel.org To: fstests@vger.kernel.org List-ID: Jeff Moyer writes: > Hi, > > When running xfs/259 against a file system that has crcs disabled, the > test will fail. The problem is that mkfs.xfs now defaults to enabling > crcs. So, when the test checks the underlying file system and finds > crcs are disabled, it tries to create a file system with a block size > that is too small to support them. The solution is to explicitly > specify the crc feature. > > Signed-off-by: Jeff Moyer > > diff --git a/tests/xfs/259 b/tests/xfs/259 > index 16c1935..e0022ce 100755 > --- a/tests/xfs/259 > +++ b/tests/xfs/259 > @@ -72,7 +72,7 @@ for del in $sizes_to_check; do > lofile=$(losetup -f) > losetup $lofile "$testfile" > "$MKFS_XFS_PROG" -l size=32m -b size=$blocksize $lofile \ > - >/dev/null || echo "mkfs failed!" > + -m crc=$_fs_has_crcs>/dev/null || echo "mkfs failed!" It occurs to me that this may break on systems using a mkfs.xfs that does not support the "-m crc" option. Is there a standard way to test for such things? -Jeff