From: Eric Biggers <ebiggers@kernel.org>
To: Alexander Larsson <alexl@redhat.com>
Cc: miklos@szeredi.hu, linux-unionfs@vger.kernel.org,
amir73il@gmail.com, tytso@mit.edu, fsverity@lists.linux.dev
Subject: Re: [PATCH v3 3/4] ovl: Validate verity xattr when resolving lowerdata
Date: Tue, 13 Jun 2023 10:57:59 -0700 [thread overview]
Message-ID: <20230613175759.GA1139@sol.localdomain> (raw)
In-Reply-To: <CAL7ro1Feep_aQimxEJzKk+4cv6-UNgco3VNDKZrrC3y2u04DCw@mail.gmail.com>
On Tue, Jun 13, 2023 at 01:41:34PM +0200, Alexander Larsson wrote:
> > Can you consider
> > https://lore.kernel.org/r/20230612190047.59755-1-ebiggers@kernel.org which would
> > make fsverity_get_digest() support both types of IDs? Then you can use
> > FS_VERITY_HASH_ALG_*, which I think would make things slightly easier for you.
>
> Sounds very good to me. I'll rebase the patchset on top of it. Not
> sure how to best land this though, are you ok with this landing via
> overlayfs-next?
If you're confident that this series will land in v6.4, then sure, you can apply
my patch "fsverity: rework fsverity_get_digest() again" to overlayfs-next,
instead of me taking it through fsverity/for-next. (Hopefully the IMA
maintainer will ack it as well, as it touches security/integrity/.)
Just be careful about being overly-optimistic about features landing in the next
release. I've had experience with cases like this before, where I didn't apply
something for a reason like this, but then the series didn't make it in right
away so it was worse than me just taking the patch in the first place.
I do see that the other prerequisites were just applied to overlayfs-next, so
maybe this is good to go now. It's up to the other overlayfs folks.
- Eric
next prev parent reply other threads:[~2023-06-13 17:58 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 10:27 [PATCH v3 0/4] ovl: Add support for fs-verity checking of lowerdata Alexander Larsson
2023-06-12 10:27 ` [PATCH v3 1/4] fsverity: Export fsverity_get_digest Alexander Larsson
2023-06-12 10:27 ` [PATCH v3 2/4] ovl: Add framework for verity support Alexander Larsson
2023-06-12 16:32 ` Eric Biggers
2023-06-13 5:18 ` Amir Goldstein
2023-06-13 6:37 ` Eric Biggers
2023-06-13 8:08 ` Alexander Larsson
2023-06-13 9:34 ` Amir Goldstein
2023-06-13 18:22 ` Eric Biggers
2023-06-14 5:24 ` Amir Goldstein
2023-06-14 7:57 ` Alexander Larsson
2023-06-15 23:52 ` Eric Biggers
2023-06-16 8:11 ` Alexander Larsson
2023-06-17 19:47 ` Eric Biggers
2023-06-19 7:58 ` Alexander Larsson
2023-06-12 10:27 ` [PATCH v3 3/4] ovl: Validate verity xattr when resolving lowerdata Alexander Larsson
2023-06-12 10:28 ` Alexander Larsson
2023-06-12 19:09 ` Eric Biggers
2023-06-13 11:41 ` Alexander Larsson
2023-06-13 17:57 ` Eric Biggers [this message]
2023-06-14 3:28 ` Eric Biggers
2023-06-14 5:39 ` Amir Goldstein
2023-06-14 7:19 ` Alexander Larsson
2023-06-12 10:28 ` [PATCH v3 4/4] ovl: Handle verity during copy-up Alexander Larsson
2023-06-12 10:52 ` Amir Goldstein
2023-06-12 10:54 ` [PATCH v3 0/4] ovl: Add support for fs-verity checking of lowerdata Amir Goldstein
2023-06-12 11:09 ` Alexander Larsson
2023-06-12 14:53 ` Alexander Larsson
2023-06-12 15:05 ` Amir Goldstein
2023-06-14 6:14 ` Amir Goldstein
2023-06-14 7:07 ` Eric Biggers
2023-06-14 7:16 ` Alexander Larsson
2023-06-22 9:36 ` Amir Goldstein
2023-06-22 9:51 ` Alexander Larsson
2023-06-22 11:45 ` Amir Goldstein
2023-06-26 13:01 ` Amir Goldstein
2023-07-03 8:11 ` Alexander Larsson
2023-07-06 7:10 ` Amir Goldstein
2023-07-06 7:50 ` Alexander Larsson
2023-06-22 16:12 ` Eric Biggers
2023-06-22 18:07 ` Amir Goldstein
2023-06-13 13:57 ` Alexander Larsson
2023-06-13 17:59 ` Eric Biggers
2023-06-14 7:15 ` Alexander Larsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230613175759.GA1139@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=alexl@redhat.com \
--cc=amir73il@gmail.com \
--cc=fsverity@lists.linux.dev \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox