Re: [PATCH RFC 06/29] fsverity: report validation errors back to the filesystem

Christoph Hellwig
2025-08-12T07:56:33Z

On Tue, Aug 12, 2025 at 09:34:55AM +0200, Christoph Hellwig wrote:
> On Mon, Aug 11, 2025 at 08:31:42AM -0700, Darrick J. Wong wrote:
> > On Mon, Aug 11, 2025 at 01:46:03PM +0200, Christoph Hellwig wrote:
> > > On Mon, Jul 28, 2025 at 10:30:10PM +0200, Andrey Albershteyn wrote:
> > > > From: "Darrick J. Wong" <djwong@kernel.org>
> > > >
> > > > Provide a new function call so that validation errors can be reported
> > > > back to the filesystem.
> > >
> > > This feels like an awfull generic name for a very specific error
> > > condition.
> >
> > <shrug> ->verity_failure?
>
> Either that or make it generic. Either way it needs to be documented
> in the usual places that document file operations including explaining
> when it is supposed to be called.

FYI, I only realized now this is actually a fsverity operation, not
a file operation. Sorry for the noise.

So maybe file_corrupt is fine, but verity_failure sounds fine to.
Maybe the fsverity maintainers have an opinion.