Re: [PATCH v2 2/22] fsverity: expose ensure_fsverity_info()

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Jan 12, 2026 at 03:49:57PM +0100, Andrey Albershteyn wrote:
> This function will be used by XFS's scrub to force fsverity activation,
> therefore, to read fsverity context.
> 
> Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>
> ---
>  fs/verity/open.c         | 4 ++--
>  include/linux/fsverity.h | 2 ++
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/verity/open.c b/fs/verity/open.c
> index 77b1c977af..956ddaffbf 100644
> --- a/fs/verity/open.c
> +++ b/fs/verity/open.c
> @@ -350,7 +350,7 @@
>  	return 0;
>  }
>  
> -static int ensure_verity_info(struct inode *inode)
> +int fsverity_ensure_verity_info(struct inode *inode)

Looks mostly fine to me, but does fsverity_ensure_verity_info needs its
own EXPORT_SYMBOL_GPL() for when xfs is built as an external module?

--D

>  {
>  	struct fsverity_info *vi = fsverity_get_info(inode);
>  	struct fsverity_descriptor *desc;
> @@ -380,7 +380,7 @@
>  {
>  	if (filp->f_mode & FMODE_WRITE)
>  		return -EPERM;
> -	return ensure_verity_info(inode);
> +	return fsverity_ensure_verity_info(inode);
>  }
>  EXPORT_SYMBOL_GPL(__fsverity_file_open);
>  
> diff --git a/include/linux/fsverity.h b/include/linux/fsverity.h
> index b75e232890..16a6e51705 100644
> --- a/include/linux/fsverity.h
> +++ b/include/linux/fsverity.h
> @@ -196,6 +196,8 @@
>  int __fsverity_prepare_setattr(struct dentry *dentry, struct iattr *attr);
>  void __fsverity_cleanup_inode(struct inode *inode);
>  
> +int fsverity_ensure_verity_info(struct inode *inode);
> +
>  /**
>   * fsverity_cleanup_inode() - free the inode's verity info, if present
>   * @inode: an inode being evicted
> 
> -- 
> - Andrey
> 
>