Re: [PATCH 07/11] fs: consolidate fsverity_info lookup in buffer.c

Christoph Hellwig
2026-01-23T07:24:37Z

On Thu, Jan 22, 2026 at 11:23:29PM -0800, Darrick J. Wong wrote:
> On Fri, Jan 23, 2026 at 06:15:56AM +0100, Christoph Hellwig wrote:
> > On Thu, Jan 22, 2026 at 01:49:58PM -0800, Darrick J. Wong wrote:
> > > Well this is no longer a weird ext4ism, since f2fs also needs this,
> > > right? Maybe this comment should read:
> >
> > f2fs doesn't use buffer heads. So this is just because ext4 only
> > implements the easy parts of ->read_folio and ->readahead itself and
> > falls back onto the generic code for the rest, which then had to be
> > grow hacky ext4-specific bits like this for it :(
>
> Yikes. So I guess we shouldn't genericise the comment to encourage more
> people to do the same thing ext4 did?

I don't think so. I actually need to send a ping to the ext4 folks
that maybe, maybe they really should handle all reads into the page
cache in their own code so that we can hopefully kill this entirely.