From: Eric Biggers <ebiggers@kernel.org>
To: Andrey Albershteyn <aalbersh@kernel.org>
Cc: fsdevel <linux-fsdevel@vger.kernel.org>,
fsverity <fsverity@lists.linux.dev>,
linux-ext4 <linux-ext4@vger.kernel.org>,
linux-btrfs <linux-btrfs@vger.kernel.org>,
linux-f2fs <linux-f2fs-devel@lists.sourceforge.net>,
linux-xfs <linux-xfs@vger.kernel.org>,
dsterba@suse.com, Christian Brauner <brauner@kernel.org>,
tytso@mit.edu, chao@kernel.org, jaegeuk@kernel.org,
viro@zeniv.linux.org.uk, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v3 3/7] fs,fsverity: add I_VERITY_BUILDING inode state flag
Date: Fri, 20 Nov 2026 22:17:44 +0000 [thread overview]
Message-ID: <20261120221744.GB3048696@google.com> (raw)
In-Reply-To: <20261120155032.187246-4-aalbersh@kernel.org>
On Fri, Nov 20, 2026 at 04:50:25PM +0100, Andrey Albershteyn wrote:
> + * I_VERITY_BUILDING fs-verity is being enabled on the inode: the Merkle
> + * tree is under construction. The file is effectively
> + * read-only to userspace; the only writes happening are
> + * for the fs-verity metadata.
Existing dirty data can still be written out though, right?
> diff --git a/include/linux/fsverity.h b/include/linux/fsverity.h
> index 61fe96ccdff6..e02f79682e33 100644
> --- a/include/linux/fsverity.h
> +++ b/include/linux/fsverity.h
> @@ -36,11 +36,12 @@ struct fsverity_operations {
> * @filp: a readonly file descriptor for the file
> *
> * The filesystem must do any needed filesystem-specific preparations
> - * for enabling verity, e.g. evicting inline data. It also must return
> - * -EBUSY if verity is already being enabled on the given file.
> + * for enabling verity, e.g. evicting inline data.
> *
> * i_rwsem is held for write.
> *
> + * I_VERITY_BUILDING is set on the inode for the duration of enabling.
> + *
> * Return: 0 on success, -errno on failure
> */
> int (*begin_enable_verity)(struct file *filp);
The new sentence doesn't seem relevant here, as the flag isn't set
during this method call.
- Eric
next prev parent reply other threads:[~2026-11-20 22:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 15:50 [PATCH v3 0/7] fsverity: lift ioctl() input masking and runtime inode flag to VFS Andrey Albershteyn
2026-11-20 15:50 ` [PATCH v3 1/7] fs: constify inode argument of inode_state_read_once() Andrey Albershteyn
2026-11-20 15:50 ` [PATCH v3 2/7] fs: strip FS_VERITY_FL from FS_IOC_SETFLAGS Andrey Albershteyn
2026-11-20 22:20 ` Eric Biggers
2026-11-20 15:50 ` [PATCH v3 3/7] fs,fsverity: add I_VERITY_BUILDING inode state flag Andrey Albershteyn
2026-11-20 22:17 ` Eric Biggers [this message]
2026-11-20 15:50 ` [PATCH v3 4/7] iomap: use fsverity_is_building() to check for fsverity IO Andrey Albershteyn
2026-11-20 16:13 ` sashiko-bot
2026-11-20 16:21 ` sashiko-bot
2026-11-20 16:42 ` Andrey Albershteyn
2026-11-20 22:23 ` Eric Biggers
2026-11-20 15:50 ` [PATCH v3 5/7] btrfs: use I_VERITY_BUILDING instead of private flags Andrey Albershteyn
2026-11-20 15:50 ` [PATCH v3 6/7] ext4: " Andrey Albershteyn
2026-11-20 15:50 ` [PATCH v3 7/7] f2fs: " Andrey Albershteyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120221744.GB3048696@google.com \
--to=ebiggers@kernel.org \
--cc=aalbersh@kernel.org \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=dsterba@suse.com \
--cc=fsverity@lists.linux.dev \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox