Re: [PATCH v2 05/23] fsverity: make fsverity_verify_folio() accept folio's offset and size

Andrey Albershteyn
2023-04-05T10:36:51Z

Hi Christoph,

On Tue, Apr 04, 2023 at 08:30:36AM -0700, Christoph Hellwig wrote:
> On Tue, Apr 04, 2023 at 04:53:01PM +0200, Andrey Albershteyn wrote:
> > Not the whole folio always need to be verified by fs-verity (e.g.
> > with 1k blocks). Use passed folio's offset and size.
>
> Why can't those callers just call fsverity_verify_blocks directly?
>

They can. Calling _verify_folio with explicit offset; size appeared
more clear to me. But I'm ok with dropping this patch to have full
folio verify function.

--
- Andrey