fsverity.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Disha Goel <disgoel@linux.ibm.com>
To: fsverity@lists.linux.dev
Cc: ebiggers@kernel.org
Subject: OpenSSL engine removal and fsverity-utils compilation issue
Date: Thu, 23 Jan 2025 16:02:46 +0530	[thread overview]
Message-ID: <d42c3dd4-47b4-4e98-9814-99cd9c1d112d@linux.ibm.com> (raw)

Hi,

Some distributions have started removing OpenSSL engine support, replacing
engine.h with an empty dummy header file. As a result, fsverity-utils fails
to compile with the following error.

Is there any plan to address this issue and support these distributions?

Please seehttps://fedoraproject.org/wiki/Changes/OpensslDeprecateEngine for more details.

# make
   CC       lib/compute_digest.o
   CC       lib/enable.o
   CC       lib/hash_algs.o
   CC       lib/sign_digest.o
lib/sign_digest.c: In function ‘load_pkcs11_private_key’:
lib/sign_digest.c:350:9: error: implicit declaration of function ‘ENGINE_load_dynamic’ [-Wimplicit-function-declaration]
   350 |         ENGINE_load_dynamic();
       |         ^~~~~~~~~~~~~~~~~~~
lib/sign_digest.c:351:18: error: implicit declaration of function ‘ENGINE_by_id’ [-Wimplicit-function-declaration]
   351 |         engine = ENGINE_by_id("dynamic");
       |                  ^~~~~~~~~~~~
lib/sign_digest.c:351:16: error: assignment to ‘ENGINE *’ {aka ‘struct engine_st *’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
   351 |         engine = ENGINE_by_id("dynamic");
       |                ^
lib/sign_digest.c:356:14: error: implicit declaration of function ‘ENGINE_ctrl_cmd_string’ [-Wimplicit-function-declaration]
   356 |         if (!ENGINE_ctrl_cmd_string(engine, "SO_PATH",
       |              ^~~~~~~~~~~~~~~~~~~~~~
lib/sign_digest.c:363:14: error: implicit declaration of function ‘ENGINE_init’ [-Wimplicit-function-declaration]
   363 |             !ENGINE_init(engine)) {
       |              ^~~~~~~~~~~
lib/sign_digest.c:365:17: error: implicit declaration of function ‘ENGINE_free’ [-Wimplicit-function-declaration]
   365 |                 ENGINE_free(engine);
       |                 ^~~~~~~~~~~
lib/sign_digest.c:368:21: error: implicit declaration of function ‘ENGINE_load_private_key’ [-Wimplicit-function-declaration]
   368 |         *pkey_ret = ENGINE_load_private_key(engine, sig_params->pkcs11_keyid,
       |                     ^~~~~~~~~~~~~~~~~~~~~~~
lib/sign_digest.c:368:19: error: assignment to ‘EVP_PKEY *’ {aka ‘struct evp_pkey_st *’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
   368 |         *pkey_ret = ENGINE_load_private_key(engine, sig_params->pkcs11_keyid,
       |                   ^
lib/sign_digest.c:370:9: error: implicit declaration of function ‘ENGINE_finish’ [-Wimplicit-function-declaration]
   370 |         ENGINE_finish(engine);
       |         ^~~~~~~~~~~~~
make: *** [Makefile:134: lib/sign_digest.o] Error 1

------
Thanks
Disha


             reply	other threads:[~2025-01-23 10:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-23 10:32 Disha Goel [this message]
2025-01-23 18:24 ` OpenSSL engine removal and fsverity-utils compilation issue Eric Biggers
2025-02-17 19:43   ` Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d42c3dd4-47b4-4e98-9814-99cd9c1d112d@linux.ibm.com \
    --to=disgoel@linux.ibm.com \
    --cc=ebiggers@kernel.org \
    --cc=fsverity@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).