Re: [PATCH 10/10] highlevel: Switch fuse_main_real_versioned() to fuse_daemonize_early()

["Darrick J. Wong" <djwong@kernel.org>]

On Fri, May 08, 2026 at 06:39:13PM +0200, Bernd Schubert via B4 Relay wrote:
> From: Bernd Schubert <bernd@bsbernd.com>
> 
> For high level we can switch directly in that function to the new daemonize
> API. Additionally we need to check if the daemon has already acticated
> daemonization to avoid warning messages.
> 
> Suggested-by: Miklos Szeredi <miklos@szeredi.hu>
> Signed-off-by: Bernd Schubert <bernd@bsbernd.com>
> ---
>  lib/helper.c | 30 +++++++++++++++++++-----------
>  1 file changed, 19 insertions(+), 11 deletions(-)
> 
> diff --git a/lib/helper.c b/lib/helper.c
> index 4d7c2b7f..15de3fbf 100644
> --- a/lib/helper.c
> +++ b/lib/helper.c
> @@ -260,6 +260,7 @@ int fuse_main_real_versioned(int argc, char *argv[],
>  	struct fuse_cmdline_opts opts;
>  	int res;
>  	struct fuse_loop_config *loop_config = NULL;
> +	bool self_daemonize = false;
>  
>  	if (fuse_parse_cmdline(&args, &opts) != 0)
>  		return 1;
> @@ -289,6 +290,21 @@ int fuse_main_real_versioned(int argc, char *argv[],
>  		goto out1;
>  	}
>  
> +	/* The application might have already started daemonization itself */
> +	if (!fuse_daemonize_early_is_active()) {
> +		int daemonize_early_flags = 0;
> +
> +		if (opts.foreground)
> +			daemonize_early_flags |= FUSE_DAEMONIZE_NO_BACKGROUND;
> +
> +		self_daemonize = true;

Technically speaking you don't have to set self_daemonize until after
the _early_start succeeds, right?

That doesn't bother me all that much, so
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> +		res = fuse_daemonize_early_start(daemonize_early_flags);
> +		if (res != 0) {
> +			fuse_log(FUSE_LOG_ERR, "fuse: daemonize_early_start failed\n");
> +			goto out1;
> +		}
> +	}
> +
>  	struct fuse *_fuse_new_31(struct fuse_args *args,
>  			       const struct fuse_operations *op, size_t op_size,
>  			       struct libfuse_version *version,
> @@ -305,22 +321,14 @@ int fuse_main_real_versioned(int argc, char *argv[],
>  		goto out2;
>  	}
>  
> -	/*
> -	 * fuse_daemonize() already checks and fails then, but we need to
> -	 * handle it gracefully here, as this is done libfuse internal
> -	 * and caller didn't ask to daemonize with old API.
> -	 */
> -	if (!fuse_daemonize_early_is_active()) {
> -		if (fuse_daemonize(opts.foreground) != 0) {
> -			res = 5;
> -			goto out3;
> -		}
> -	}
>  	if (fuse_set_signal_handlers(se) != 0) {
>  		res = 6;
>  		goto out3;
>  	}
>  
> +	if (self_daemonize)
> +		fuse_daemonize_early_success();
> +
>  	if (opts.singlethread)
>  		res = fuse_loop(fuse);
>  	else {
> 
> -- 
> 2.53.0
> 
>