Re: [PATCH v1 00/13] fuse: dir.c cleanups

[Amir Goldstein <amir73il@gmail.com>]

On Thu, Apr 23, 2026 at 06:16:33PM -0700, Joanne Koong wrote:
> Amir expressed his unhappiness [1] with some of the code structure in dir.c,
> particularly fuse_dentry_revalidate().
> 
> This patchset is a series of cleanups in dir.c. There are no functional
> changes intended (except for the first patch).

I think this is not a good idea.
These sort of cleanup (e.g. removing unneeded gotos) are a kin to
whitespace cleanups - we should not do them unless going to change
the function for another reason.

The churn this creates and backporting conflicts are not worth the
win of the cleanup itself.

Therefore, please drop all but the fuse_dentry_revalidate() patch
which should be part of your passthrough series.

I will review only this one patch.

Thanks,
Amir.

> 
> Thanks,
> Joanne
> 
> [1] https://lore.kernel.org/fuse-devel/CAOQ4uxgCezMh3jdp519Lp9OZeqAyZHmc4Mp3FthJpfXhVoHEfw@mail.gmail.com/
> 
> Joanne Koong (13):
>   fuse: fix missing forget requests in error paths
>   fuse: clean up fuse_lookup_name()
>   fuse: clean up fuse_lookup()
>   fuse: clean up fuse_dentry_revalidate()
>   fuse: clean up fuse_create_open()
>   fuse: clean up fuse_rename2()
>   fuse: clean up fuse_time_to_jiffies()
>   fuse: clean up fuse_link()
>   fuse: clean up fuse_do_getattr()
>   fuse: clean up fuse_update_get_attr()
>   fuse: clean up fuse_get_link()
>   fuse: clean up fuse_dir_open()
>   fuse: clean up setattr()
> 
>  fs/fuse/dir.c | 324 ++++++++++++++++++++++++--------------------------
>  1 file changed, 154 insertions(+), 170 deletions(-)
> 
> -- 
> 2.52.0
>