From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f172.google.com (mail-vk1-f172.google.com [209.85.221.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D469B481FB9 for ; Thu, 6 Aug 2026 16:59:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786035572; cv=none; b=Q9j9rF/3cQiuMBntm+Sw0/EN7JdIeDd51M+zFEMfLfqQkAw10mVnwnvIhI7KWk+rwyBpdmhXK/rXGIP6+41WyyCIv322xEmH/k+o8YxXVwtKs9upNDwLIghLWi+chcH6lGo47eVEl9z1e7fCLXp1MAawvxwKCRwiIRP4x7VlOT8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786035572; c=relaxed/simple; bh=XCQvARYs03Jg6cCkHO2H308pJ7dd7LthVfdbsY3TGbk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jrjv7jsXMbK9zHS65qlgtTwSoP672hdP4LKqyTrMm08knp5XTuZLnW/PQ+v+KPjvlcLzNS+8Ixg7yLLnM3MzoL9kaC/jlxRu4pp0c3Xcnm9XqY0YrM1Zf8uK+x3Kc7olJbPTxez2zJu3Vug3fmN0Te+XwWGJL2AWL5TR1AaT694= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=neTsUu6+; arc=none smtp.client-ip=209.85.221.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="neTsUu6+" Received: by mail-vk1-f172.google.com with SMTP id 71dfb90a1353d-5bf94664327so1024473e0c.1 for ; Thu, 06 Aug 2026 09:59:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786035570; x=1786640370; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=W/UkvZ9btqQ9UcKZM3gfiOG/tPkCxSDzu5UxeQemPOo=; b=neTsUu6+8y2GVc5zjdzRU8MBj9g4jerbpD+I6DGhRi4KBXg6RwVexAGu2/cq0R4G5W 2acY5UxhyLQacOUeWJFL8s7A+DEuw0bQ0d/giM2TxKGXh/SXpLhO0DM8MPwlTdm74mAW NyqoSRJOaZbVmCjNyxwfuJWWkElk8YT5jSUkCRj1HV1ZIx4X4iaRxbJiyaqh22PQc7sb YjeTm7DNmCM4nxD2aKyJCIOINOdRjfybhKB73HT59NC6ISI8N3FEi+qPPaPnrS8lImBO bHIk43luPbGjZrfPlNGzjakb8iTVzj8gmprxBKYsLhGQ9C0fjGWChLVmacJUPTe9JWRw 5cUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786035570; x=1786640370; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=W/UkvZ9btqQ9UcKZM3gfiOG/tPkCxSDzu5UxeQemPOo=; b=gM+mExkOv3fc5ggReXQIcrP+zmvON9uyY7HRxyEuQkymHliy/VLjwMqtbJI5zkAPR9 I2aozSTZnSqo8TWAM9Xy7hrwBApA15/ruImGekWG99THVjY3u1adgWRzcErE8mPyhE37 6MB6PQh0SAfLzJEaML7WV1bL4MifVegAIcNP0bBk3xmW8N3xL2BnypcRC93h8mW9Rljb Oti2SHUXEzAIY+sf1DfbSXhknvB3FLaSWdbKANuPtT7RYG2z0fx5O3naJ1bLyzcXp9tE DcWyfdReomiTjDKJsCuySHmkYkZYRJ0UUMQ/F+DtZodjKQqYcxXIP3ljq18r9/joev8i lsgg== X-Forwarded-Encrypted: i=1; AHgh+Rpo3i7zxhmN9WW1Ri0ENIR0gzvVnmVnnDuEwGz/3qBZm0uzPKyndbQf+N4+CKNCJrmrGdIq@lists.linux.dev X-Gm-Message-State: AOJu0Yz28Pq55qt50MrJ8eAEXHwEqvItoHszZe3nSh9ETAYUx5AYn9Hv 0IRVIqaQ9Vg/RVHc6uH/L55uVu1BYhUO8gXWbSrazB1hghilFksoNshD X-Gm-Gg: AR+sD10byS80aLGJDsBj/ad9rvUGvQWvUgEKaLxAz7Yld4dfxBQ7qLGOwF5aA6KR76y a0EGkhceay2oLSx3rabLDS+taUHGK7BCwsQJ3Q03cWdyAQbe2Ahwg9+L4C3qEdRUO5J8jPVuqaE q9id720VDTXYdoxtlSDcX5cm+Lp3/GkMtCWPwQi/YEb0sJe9Dj6JIEDlztdEByPUObwjSb7L4eI 43ZQB6g3ycGxfgJuT+9PDCQLY12fLnRY515OVuqa5cGHxc3dOTSZuROODmiD+lZI09QZLoc9/vE YWsynHX3q2KTynS5xBTe36CV0laUJCpNovkSitNSDLgoi40lWXIsbrEL7XjvOqaYsieRMRSP5t3 5Ot3o1BArlMVkdokme4nxFgRVCfNmXyYN7lU9qabs4z1WjzzLdqWeBAayltKFMaVGg6nSr8vBNO JQIy3G6M0wua2zU5ly8gEmsq07CXdvmNrK9yscNgdfzVMgiFA0GTNvZt89FZSlpzUSMDFC+ZuYH +ZUjz0fFRtV2oF8lg== X-Received: by 2002:a05:6122:e248:b0:5bf:9bd1:791 with SMTP id 71dfb90a1353d-5c3d912095cmr2047468e0c.1.1786035569648; Thu, 06 Aug 2026 09:59:29 -0700 (PDT) Received: from syssplab.cs.fiu.edu (nat1.cs.fiu.edu. [131.94.134.89]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-5c3d05c594fsm3706321e0c.8.2026.08.06.09.59.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2026 09:59:29 -0700 (PDT) From: Chao Shi To: Jan Kara , Christian Brauner , Alexander Viro , Matthew Wilcox , linux-fsdevel@vger.kernel.org Cc: Theodore Ts'o , Andreas Dilger , Baokun Li , Ojaswin Mujoo , Ritesh Harjani , Zhang Yi , Zhang Yi , Bob Copeland , Namjae Jeon , Sungjong Seo , Yuezhang Mo , OGAWA Hirofumi , Mark Fasheh , Joel Becker , Joseph Qi , Andreas Gruenbacher , linux-ext4@vger.kernel.org, ocfs2-devel@lists.linux.dev, gfs2@lists.linux.dev, linux-kernel@vger.kernel.org, Chao Shi , Weidong Zhu Subject: [PATCH v2 08/21] adfs: check for a directory write error with buffer_write_io_error() Date: Thu, 6 Aug 2026 12:58:31 -0400 Message-ID: <05cf8ad911ad7a6eb68f42e38f1eea39c38e246b.1785951556.git.coshi036@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: gfs2@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit adfs_dir_sync() spots a failed write by testing BH_Req together with !BH_Uptodate. That relies on the write completion handler clearing BH_Uptodate on error, which this series removes: a buffer whose write failed still holds the data the filesystem asked to be written, so declaring it not up to date is wrong and makes callers re-read it. BH_Write_EIO says exactly what this code wants to know, and it implies BH_Req, so the pair collapses into one test. No behaviour change today - a failed write sets BH_Write_EIO and clears BH_Uptodate together. It stops being a no-op at the end of the series, where the new test is the one that still works. Acked-by: Weidong Zhu Signed-off-by: Chao Shi --- fs/adfs/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/adfs/dir.c b/fs/adfs/dir.c index 11afa9e157aa..b8cc6a697a05 100644 --- a/fs/adfs/dir.c +++ b/fs/adfs/dir.c @@ -191,7 +191,7 @@ static int adfs_dir_sync(struct adfs_dir *dir) for (i = dir->nr_buffers - 1; i >= 0; i--) { struct buffer_head *bh = dir->bhs[i]; sync_dirty_buffer(bh); - if (buffer_req(bh) && !buffer_uptodate(bh)) + if (buffer_write_io_error(bh)) err = -EIO; } -- 2.43.0