Re: [PATCH 16/17] zonefs: use bdev_rw_virt in zonefs_read_super

hch
2025-04-29T12:31:36Z

On Tue, Apr 29, 2025 at 11:44:37AM +0000, Johannes Thumshirn wrote:
> On 22.04.25 16:31, Christoph Hellwig wrote:
> > + super = kmalloc(PAGE_SIZE, GFP_KERNEL);
> > + if (!super)
>
> [...]
>
> > + ret = bdev_rw_virt(sb->s_bdev, 0, super, PAGE_SIZE, REQ_OP_READ);
>
> Can we change these two PAGE_SIZE into ZONEFS_SUPER_SIZE which is
> semantically more correct?

I'd like to keep this change mechanical, even if I'm in violent agreement
about using the right constants.