public inbox for gfs2@lists.linux.dev
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: oe-kbuild-all@lists.linux.dev, gfs2@lists.linux.dev
Subject: [gfs2:alloc 52/70] fs/gfs2/bmap.c:156: warning: Function parameter or member 'inode' not described in 'gfs2_unstuff_inode'
Date: Mon, 30 Oct 2023 08:12:40 +0800	[thread overview]
Message-ID: <202310300846.4xot9nPs-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git alloc
head:   f8dd6e4dd990a2524b3d76fd2459d027628420eb
commit: 40fddc85a985824fba577aeb19b4f5c2cc8bb34f [52/70] gfs2: Rename gfs2_unstuff_dinode to gfs2_unstuff_inode
config: loongarch-randconfig-002-20231030 (https://download.01.org/0day-ci/archive/20231030/202310300846.4xot9nPs-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231030/202310300846.4xot9nPs-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310300846.4xot9nPs-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> fs/gfs2/bmap.c:156: warning: Function parameter or member 'inode' not described in 'gfs2_unstuff_inode'
>> fs/gfs2/bmap.c:156: warning: Excess function parameter 'ip' description in 'gfs2_unstuff_inode'


vim +156 fs/gfs2/bmap.c

7a607a41cdc6c6 Andreas Gruenbacher     2021-06-17  144  
7a607a41cdc6c6 Andreas Gruenbacher     2021-06-17  145  /**
40fddc85a98582 Andreas Gruenbacher     2023-10-23  146   * gfs2_unstuff_inode - Unstuff an inode when the data has grown too big
7a607a41cdc6c6 Andreas Gruenbacher     2021-06-17  147   * @ip: The GFS2 inode to unstuff
7a607a41cdc6c6 Andreas Gruenbacher     2021-06-17  148   *
40fddc85a98582 Andreas Gruenbacher     2023-10-23  149   * This routine unstuffs an inode and returns it to a "normal" state such
7a607a41cdc6c6 Andreas Gruenbacher     2021-06-17  150   * that the height can be grown in the traditional way.
7a607a41cdc6c6 Andreas Gruenbacher     2021-06-17  151   *
7a607a41cdc6c6 Andreas Gruenbacher     2021-06-17  152   * Returns: errno
7a607a41cdc6c6 Andreas Gruenbacher     2021-06-17  153   */
7a607a41cdc6c6 Andreas Gruenbacher     2021-06-17  154  
40fddc85a98582 Andreas Gruenbacher     2023-10-23  155  int gfs2_unstuff_inode(struct inode *inode)
7a607a41cdc6c6 Andreas Gruenbacher     2021-06-17 @156  {
40fddc85a98582 Andreas Gruenbacher     2023-10-23  157  	struct gfs2_inode *ip = GFS2_I(inode);
2ccec3b8456f65 Matthew Wilcox (Oracle  2023-10-16  158) 	struct folio *folio;
7a607a41cdc6c6 Andreas Gruenbacher     2021-06-17  159  	int error;
7a607a41cdc6c6 Andreas Gruenbacher     2021-06-17  160  
7a607a41cdc6c6 Andreas Gruenbacher     2021-06-17  161  	down_write(&ip->i_rw_mutex);
2ccec3b8456f65 Matthew Wilcox (Oracle  2023-10-16  162) 	folio = filemap_grab_folio(inode->i_mapping, 0);
2ccec3b8456f65 Matthew Wilcox (Oracle  2023-10-16  163) 	error = PTR_ERR(folio);
2ccec3b8456f65 Matthew Wilcox (Oracle  2023-10-16  164) 	if (IS_ERR(folio))
7a607a41cdc6c6 Andreas Gruenbacher     2021-06-17  165  		goto out;
2ccec3b8456f65 Matthew Wilcox (Oracle  2023-10-16  166) 	error = __gfs2_unstuff_inode(ip, folio);
2ccec3b8456f65 Matthew Wilcox (Oracle  2023-10-16  167) 	folio_unlock(folio);
2ccec3b8456f65 Matthew Wilcox (Oracle  2023-10-16  168) 	folio_put(folio);
b3b94faa5fe596 David Teigland          2006-01-16  169  out:
b3b94faa5fe596 David Teigland          2006-01-16  170  	up_write(&ip->i_rw_mutex);
b3b94faa5fe596 David Teigland          2006-01-16  171  	return error;
b3b94faa5fe596 David Teigland          2006-01-16  172  }
b3b94faa5fe596 David Teigland          2006-01-16  173  

:::::: The code at line 156 was first introduced by commit
:::::: 7a607a41cdc6c6f27b8e234cb44ce57070513dac gfs2: Clean up gfs2_unstuff_dinode

:::::: TO: Andreas Gruenbacher <agruenba@redhat.com>
:::::: CC: Andreas Gruenbacher <agruenba@redhat.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2023-10-30  0:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202310300846.4xot9nPs-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=agruenba@redhat.com \
    --cc=gfs2@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox