From: Andreas Gruenbacher <agruenba@redhat.com>
To: gfs2@lists.linux.dev
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Andreas Gruenbacher <agruenba@redhat.com>
Subject: [PATCH 0/9] gfs2: Bugs in "Use GL_NOBLOCK flag for non-blocking lookups"
Date: Fri, 19 Jan 2024 22:20:47 +0100 [thread overview]
Message-ID: <20240119212056.805617-1-agruenba@redhat.com> (raw)
Hello,
Al Viro has reported issues with commit dd00aaeb3432 ("gfs2: Use
GL_NOBLOCK flag for non-blocking lookups"):
* First, parent can now be NULL and dereferencing it in
gfs2_dir_check(d_inode(parent), &dentry->d_name, ip) isn't going to
work;
* Second, gfs2_dir_check() can still sleep, which breaks LOOKUP_RCU
mode.
These patches should fix both of these problems. We'll either need
these fixes added, or commit dd00aaeb3432 reverted for now.
Thanks,
Andreas
Andreas Gruenbacher (9):
gfs2: Fix gfs2_drevalidate NULL pointer dereference
gfs2: Pass FGP flags to gfs2_getbuf
gfs2: Split gfs2_meta_read_async off from gfs2_meta_read
gfs2: Add FGP_NOWAIT support to gfs2_meta_read_async
gfs2: Pass FGP flags to gfs2_meta_{,inode_}buffer
gfs2: Pass FGP flags to gfs2_dirent_search
gfs2: Pass FGP flags to gfs2_dir_check
gfs2: Minor gfs2_drevalidate cleanup
gfs2: Fix LOOKUP_RCU support in gfs2_drevalidate
fs/gfs2/aops.c | 4 +-
fs/gfs2/bmap.c | 21 ++++----
fs/gfs2/dentry.c | 32 ++++++++-----
fs/gfs2/dir.c | 52 +++++++++++---------
fs/gfs2/dir.h | 2 +-
fs/gfs2/file.c | 4 +-
fs/gfs2/glops.c | 2 +-
fs/gfs2/incore.h | 1 -
fs/gfs2/inode.c | 10 ++--
fs/gfs2/meta_io.c | 112 ++++++++++++++++++++++++++++---------------
fs/gfs2/meta_io.h | 15 +++---
fs/gfs2/ops_fstype.c | 4 +-
fs/gfs2/quota.c | 2 +-
fs/gfs2/recovery.c | 2 +-
fs/gfs2/rgrp.c | 5 +-
fs/gfs2/super.c | 6 +--
fs/gfs2/xattr.c | 17 ++++---
17 files changed, 173 insertions(+), 118 deletions(-)
--
2.43.0
next reply other threads:[~2024-01-19 21:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 21:20 Andreas Gruenbacher [this message]
2024-01-19 21:20 ` [PATCH 1/9] gfs2: Fix gfs2_drevalidate NULL pointer dereference Andreas Gruenbacher
2024-01-19 21:20 ` [PATCH 2/9] gfs2: Pass FGP flags to gfs2_getbuf Andreas Gruenbacher
2024-01-19 21:20 ` [PATCH 3/9] gfs2: Split gfs2_meta_read_async off from gfs2_meta_read Andreas Gruenbacher
2024-01-19 21:20 ` [PATCH 4/9] gfs2: Add FGP_NOWAIT support to gfs2_meta_read_async Andreas Gruenbacher
2024-01-19 21:20 ` [PATCH 5/9] gfs2: Pass FGP flags to gfs2_meta_{,inode_}buffer Andreas Gruenbacher
2024-01-19 21:20 ` [PATCH 6/9] gfs2: Pass FGP flags to gfs2_dirent_search Andreas Gruenbacher
2024-01-19 21:20 ` [PATCH 7/9] gfs2: Pass FGP flags to gfs2_dir_check Andreas Gruenbacher
2024-01-19 21:20 ` [PATCH 8/9] gfs2: Minor gfs2_drevalidate cleanup Andreas Gruenbacher
2024-01-19 21:20 ` [PATCH 9/9] gfs2: Fix LOOKUP_RCU support in gfs2_drevalidate Andreas Gruenbacher
2024-01-20 1:36 ` [PATCH 0/9] gfs2: Bugs in "Use GL_NOBLOCK flag for non-blocking lookups" Al Viro
2024-01-20 1:38 ` Al Viro
2024-01-22 12:52 ` Andrew Price
2024-02-02 4:23 ` Al Viro
2024-02-02 4:34 ` Al Viro
2024-02-02 16:32 ` Andreas Gruenbacher
2024-02-02 4:59 ` Al Viro
2024-02-02 5:02 ` Al Viro
2024-02-02 17:09 ` Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240119212056.805617-1-agruenba@redhat.com \
--to=agruenba@redhat.com \
--cc=gfs2@lists.linux.dev \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox