public inbox for gfs2@lists.linux.dev
 help / color / mirror / Atom feed
From: Alexander Aring <aahringo@redhat.com>
To: teigland@redhat.com
Cc: gfs2@lists.linux.dev, aahringo@redhat.com
Subject: [RFC v6.8-rc6 0/7] dlm: fix race between callback and remove message
Date: Fri,  8 Mar 2024 11:18:11 -0500	[thread overview]
Message-ID: <20240308161818.2388451-1-aahringo@redhat.com> (raw)

Hi,

this patch fixes some race I hit between the last callback from a lkb
and a potential remove message if this callback was not delivered yet.
The issue has something todo that we held in some situation the lkb
reference which we should not. There are also some other places affected
(e.g. debugfs dump) that I am also working on to solve them. I tried to
split my work in several patches to reduce the amount of changes in the
fix of patch "dlm: fix race between final callback and remove".

I also found a issue with the lvb copy for user space locks I introduced
that should be fixed, see "dlm: fix user space lock decision to copy
lvb".

- Alex

Alexander Aring (7):
  dlm: fix user space lock decision to copy lvb
  dlm: remove lkb from ast bast tracepoints
  dlm: remove callback queue debugfs functionality
  dlm: move lkb debug information out of callback
  dlm: combine switch case fail and default statements
  dlm: fix race between final callback and remove
  dlm: remove callback reference counting

 fs/dlm/ast.c               | 203 +++++++++++++++----------------------
 fs/dlm/ast.h               |  13 +--
 fs/dlm/debug_fs.c          |  98 +-----------------
 fs/dlm/dlm_internal.h      |  66 +++++++-----
 fs/dlm/lock.c              |  24 ++---
 fs/dlm/memory.c            |   4 -
 fs/dlm/user.c              | 107 +++++--------------
 include/trace/events/dlm.h |  46 ++++-----
 8 files changed, 182 insertions(+), 379 deletions(-)

-- 
2.43.0


             reply	other threads:[~2024-03-08 16:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-08 16:18 Alexander Aring [this message]
2024-03-08 16:18 ` [RFC v6.8-rc6 1/7] dlm: fix user space lock decision to copy lvb Alexander Aring
2024-03-10 14:27   ` Alexander Aring
2024-03-08 16:18 ` [RFC v6.8-rc6 2/7] dlm: remove lkb from ast bast tracepoints Alexander Aring
2024-03-08 16:18 ` [RFC v6.8-rc6 3/7] dlm: remove callback queue debugfs functionality Alexander Aring
2024-03-08 16:18 ` [RFC v6.8-rc6 4/7] dlm: move lkb debug information out of callback Alexander Aring
2024-03-08 16:18 ` [RFC v6.8-rc6 5/7] dlm: combine switch case fail and default statements Alexander Aring
2024-03-08 16:18 ` [RFC v6.8-rc6 6/7] dlm: fix race between final callback and remove Alexander Aring
2024-03-08 16:30   ` Alexander Aring
2024-03-13 13:46   ` Alexander Aring
2024-03-08 16:18 ` [RFC v6.8-rc6 7/7] dlm: remove callback reference counting Alexander Aring
2024-03-10 14:25   ` Alexander Aring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240308161818.2388451-1-aahringo@redhat.com \
    --to=aahringo@redhat.com \
    --cc=gfs2@lists.linux.dev \
    --cc=teigland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox