[PATCH] gfs2: Fix do_xmote locking error

[Andreas Gruenbacher <agruenba@redhat.com>]

Commit 86934198eefa added a 'goto' statement from the beginning of
do_xmote() to further below where the glock spinlock must no longer be
held.  I don't fully understand what's going on here, and apparently
this case isn't covered by our testing.  In any case though, we must
drop the glock spinlock before this 'goto' or else we won't be able to
retake the lock at the end of do_xmote().

Fixes: 86934198eefa ("gfs2: Clear flags when withdraw prevents xmote")
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
---
 fs/gfs2/glock.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index ce62937d85b5..2c9fdc3f7d76 100644
--- a/fs/gfs2/glock.c
+++ b/fs/gfs2/glock.c
@@ -705,8 +705,10 @@ __acquires(&gl->gl_lockref.lock)
 	int ret;
 
 	if (target != LM_ST_UNLOCKED && glock_blocked_by_withdraw(gl) &&
-	    gh && !(gh->gh_flags & LM_FLAG_NOEXP))
+	    gh && !(gh->gh_flags & LM_FLAG_NOEXP)) {
+		spin_unlock(&gl->gl_lockref.lock);
 		goto skip_inval;
+	}
 
 	lck_flags &= (LM_FLAG_TRY | LM_FLAG_TRY_1CB | LM_FLAG_NOEXP);
 	GLOCK_BUG_ON(gl, gl->gl_state == target);
-- 
2.44.0