Re: [PATCH v4 16/16] xfs: add pre-content fsnotify hook for write faults

Christian Brauner
2024-09-02T11:19:34Z

On Mon, Sep 02, 2024 at 12:23:44PM GMT, Jan Kara wrote:
> On Fri 30-08-24 16:28:33, Darrick J. Wong wrote:
> > On Thu, Aug 29, 2024 at 01:17:53PM +0200, Jan Kara wrote:
> > > On Wed 14-08-24 17:25:34, Josef Bacik wrote:
> > > > xfs has it's own handling for write faults, so we need to add the
> > > > pre-content fsnotify hook for this case. Reads go through filemap_fault
> > > > so they're handled properly there.
> > > >
> > > > Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> > >
> > > Looks good to me but it would be great to get explicit ack from some XFS
> > > guy... Some selection CCed :)
> >
> > Looks decent to me, but I wonder why xfs_write_fault has to invoke
> > filemap_maybe_emit_fsnotify_event itself? Can that be done from
> > whatever calls ->page_mkwrite and friends?
>
> So we were discussing this already here [1]. The options we have:
>
> 1) Call filemap_maybe_emit_fsnotify_event() from filesystem hooks

Sidenote: Can that be renamed to filemap_fsnotify() or something
similar. Especially that "maybe" in there really doesn't add value imho.