Re: [PATCH v4 14/16] bcachefs: add pre-content fsnotify hook to fault

Kent Overstreet
2024-08-29T11:26:51Z

On Thu, Aug 29, 2024 at 01:10:55PM GMT, Jan Kara wrote:
> On Wed 14-08-24 17:25:32, Josef Bacik wrote:
> > bcachefs has its own locking around filemap_fault, so we have to make
> > sure we do the fsnotify hook before the locking. Add the check to emit
> > the event before the locking and return VM_FAULT_RETRY to retrigger the
> > fault once the event has been emitted.
> >
> > Signed-off-by: Josef Bacik <josef@toxicpanda.com>
>
> Looks good to me. Would be nice to get ack from bcachefs guys. Kent?

I said I wanted the bcachefs side tested, and offered Josef CI access
for that - still waiting to hear from him.