public inbox for gfs2@lists.linux.dev
 help / color / mirror / Atom feed
From: Andreas Gruenbacher <agruenba@redhat.com>
To: gfs2@lists.linux.dev
Cc: Andreas Gruenbacher <agruenba@redhat.com>
Subject: [PATCH 00/16] gfs2: unlinked inodes
Date: Thu, 26 Sep 2024 00:03:10 +0200	[thread overview]
Message-ID: <20240925220331.417856-1-agruenba@redhat.com> (raw)

We have recently run into cases where unlinked inodes end up
accumulating.  This should only happen as a result of cluster node
failures, and those unlinked inodes should be cleaned up during
allocations.  Sometimes, for some reason, neiter happened.

In turns out that this is mainly due to a bug in commit f0e56edc2ec7
("gfs2: Split the two kinds of glock "delete" work"); see patch "gfs2:
Fix unlinked inode cleanup".

While going through the relevant parts of the code, I noticed a number
of additional minor problems which this patch set addresses as well.

Any thoughts?

Thanks,
Andreas

Andreas Gruenbacher (16):
  gfs2: Rename GLF_VERIFY_EVICT to GLF_VERIFY_DELETE
  gfs2: Initialize gl_no_formal_ino earlier
  gfs2: Allow immediate GLF_VERIFY_DELETE work
  gfs2: Fix unlinked inode cleanup
  gfs2: Faster gfs2_upgrade_iopen_glock wakeups
  gfs2: Rename GIF_{DEFERRED -> DEFER}_DELETE
  gfs2: Rename dinode_demise to evict_behavior
  gfs2: Return enum evict_behavior from gfs2_upgrade_iopen_glock
  gfs2: Minor delete_work_func cleanup
  gfs2: Clean up delete work processing
  gfs2: Call gfs2_queue_verify_delete from gfs2_evict_inode
  gfs2: Update to the evict / remote delete documentation
  gfs2: Use mod_delayed_work in gfs2_queue_try_to_evict
  gfs2: Randomize GLF_VERIFY_DELETE work delay
  gfs2: Use get_random_u32 in gfs2_orlov_skip
  gfs2: Make gfs2_inode_refresh static

 fs/gfs2/glock.c  | 100 ++++++++++++++++-------------------------------
 fs/gfs2/glock.h  |   7 ++++
 fs/gfs2/glops.c  |  11 +++++-
 fs/gfs2/incore.h |   4 +-
 fs/gfs2/inode.c  |   1 +
 fs/gfs2/inode.h  |   2 -
 fs/gfs2/rgrp.c   |   6 +--
 fs/gfs2/super.c  |  76 +++++++++++++++++++++--------------
 8 files changed, 101 insertions(+), 106 deletions(-)

-- 
2.46.0


             reply	other threads:[~2024-09-25 22:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-25 22:03 Andreas Gruenbacher [this message]
2024-09-25 22:03 ` [PATCH 01/16] gfs2: Rename GLF_VERIFY_EVICT to GLF_VERIFY_DELETE Andreas Gruenbacher
2024-09-25 22:03 ` [PATCH 02/16] gfs2: Initialize gl_no_formal_ino earlier Andreas Gruenbacher
2024-09-25 22:03 ` [PATCH 03/16] gfs2: Allow immediate GLF_VERIFY_DELETE work Andreas Gruenbacher
2024-09-25 22:03 ` [PATCH 04/16] gfs2: Fix unlinked inode cleanup Andreas Gruenbacher
2024-09-25 22:03 ` [PATCH 05/16] gfs2: Faster gfs2_upgrade_iopen_glock wakeups Andreas Gruenbacher
2024-09-25 22:03 ` [PATCH 06/16] gfs2: Rename GIF_{DEFERRED -> DEFER}_DELETE Andreas Gruenbacher
2024-09-25 22:03 ` [PATCH 07/16] gfs2: Rename dinode_demise to evict_behavior Andreas Gruenbacher
2024-09-25 22:03 ` [PATCH 08/16] gfs2: Return enum evict_behavior from gfs2_upgrade_iopen_glock Andreas Gruenbacher
2024-09-25 22:03 ` [PATCH 09/16] gfs2: Minor delete_work_func cleanup Andreas Gruenbacher
2024-09-25 22:03 ` [PATCH 10/16] gfs2: Clean up delete work processing Andreas Gruenbacher
2024-09-25 22:03 ` [PATCH 11/16] gfs2: Call gfs2_queue_verify_delete from gfs2_evict_inode Andreas Gruenbacher
2024-09-25 22:03 ` [PATCH 12/16] gfs2: Update to the evict / remote delete documentation Andreas Gruenbacher
2024-09-25 22:03 ` [PATCH 13/16] gfs2: Use mod_delayed_work in gfs2_queue_try_to_evict Andreas Gruenbacher
2024-09-25 22:03 ` [PATCH 14/16] gfs2: Randomize GLF_VERIFY_DELETE work delay Andreas Gruenbacher
2024-09-25 22:03 ` [PATCH 15/16] gfs2: Use get_random_u32 in gfs2_orlov_skip Andreas Gruenbacher
2024-09-25 22:03 ` [PATCH 16/16] gfs2: Make gfs2_inode_refresh static Andreas Gruenbacher
2024-09-26 12:18 ` [PATCH 00/16] gfs2: unlinked inodes Andrew Price

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240925220331.417856-1-agruenba@redhat.com \
    --to=agruenba@redhat.com \
    --cc=gfs2@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox