From: Mark Syms <mark.syms@cloud.com>
To: <gfs2@lists.linux.dev>
Cc: Mark Syms <mark.syms@cloud.com>
Subject: [PATCH] gfs2_grow: Optionally allow not issuing discard requests
Date: Wed, 19 Feb 2025 15:20:46 +0000 [thread overview]
Message-ID: <20250219152046.350786-1-mark.syms@cloud.com> (raw)
mkfs.gfs2 supports a -K option which disables issuing discard requests
for unused blocks on the LUN. gfs2_grow does not have an equivalent
option so even if the filesystem was originally created with the -K
option a subsequent grow operation will incur the, potentially high,
cost of performing the discard.
Signed-off-by: Mark Syms <mark.syms@cloud.com>
---
gfs2/mkfs/main_grow.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/gfs2/mkfs/main_grow.c b/gfs2/mkfs/main_grow.c
index e378a668..d2052604 100644
--- a/gfs2/mkfs/main_grow.c
+++ b/gfs2/mkfs/main_grow.c
@@ -31,6 +31,7 @@
static uint64_t override_device_size = 0;
static int test = 0;
static uint64_t fssize = 0, fsgrowth;
+static int skip_discard = 0;
int print_level = MSG_NOTICE;
extern int create_new_inode(struct lgfs2_sbd *sdp);
@@ -72,6 +73,7 @@ static void usage(void)
"-T", NULL, _("Do everything except update file system"),
"-V", NULL, _("Display version information"),
"-v", NULL, _("Increase verbosity"),
+ "-K", NULL, _("Don't try to discard unused blocks"),
NULL, NULL, NULL /* Must be kept at the end */
};
@@ -92,7 +94,7 @@ static void decode_arguments(int argc, char *argv[], struct lgfs2_sbd *sdp)
{
int opt;
- while ((opt = getopt(argc, argv, "VD:hqTv?")) != EOF) {
+ while ((opt = getopt(argc, argv, "VD:hqTv?K")) != EOF) {
switch (opt) {
case 'D': /* This option is for testing only */
override_device_size = atoi(optarg);
@@ -116,6 +118,9 @@ static void decode_arguments(int argc, char *argv[], struct lgfs2_sbd *sdp)
case 'v':
increase_verbosity();
break;
+ case 'K':
+ skip_discard = 1;
+ break;
case ':':
case '?':
/* Unknown flag */
@@ -207,7 +212,9 @@ static unsigned initialize_new_portion(struct lgfs2_sbd *sdp, lgfs2_rgrps_t rgs)
unsigned rgcount = 0;
uint64_t rgaddr = fssize;
- discard_blocks(sdp->device_fd, rgaddr * sdp->sd_bsize, fsgrowth * sdp->sd_bsize);
+ if (skip_discard == 0)
+ discard_blocks(sdp->device_fd, rgaddr * sdp->sd_bsize, fsgrowth * sdp->sd_bsize);
+
/* Build the remaining resource groups */
while (1) {
int err = 0;
--
2.48.1
next reply other threads:[~2025-02-19 15:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 15:20 Mark Syms [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-02-19 15:21 [PATCH] gfs2_grow: Optionally allow not issuing discard requests Mark Syms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250219152046.350786-1-mark.syms@cloud.com \
--to=mark.syms@cloud.com \
--cc=gfs2@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox