Re: [PATCH 8/8] gfs2: use lockref_init for qd_lockref

Christian Brauner
2025-01-20T15:25:24Z

On Fri, Jan 17, 2025 at 05:03:51PM +0100, Andreas Gruenbacher wrote:
> On Thu, 16 Jan 2025 05:32:26 +0100, Christoph Hellwig <hch@lst.de> wrote:
> > Well, if you can fix it to start with 1 we could start out with 1
> > as the default. FYI, I also didn't touch the other gfs2 lockref
> > because it initialize the lock in the slab init_once callback and
> > the count on every initialization.
>
> Sure, can you add the below patch before the lockref_init conversion?
>
> Thanks,
> Andreas
>
> --
>
> gfs2: Prepare for converting to lockref_init
>
> First, move initializing the glock lockref spin lock from
> gfs2_init_glock_once() to gfs2_glock_get().
>
> Second, in qd_alloc(), initialize the lockref count to 1 to cover the
> common case. Compensate for that in gfs2_quota_init() by adjusting the
> count back down to 0; this case occurs only when mounting the filesystem
> rw.
>
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
> ---

Can you send this as a proper separae patch, please?