From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F16291C3F36 for ; Tue, 23 Sep 2025 00:34:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758587651; cv=none; b=GwxrIhOtZ9tTyPRmJATjL2FKbHKNoP13wEiViObHoxPDwExFqQqihQ27ejwlSaTQMQFdE8BgAvRm29pBdAY6yqOMa56DnqoLCqfGvg7FJSmdi0iKenLFWq2Sfxn6AipmlkS43aYae9WjNoAvAbXYK5srv1QaHtz5ydDLIzD+7cg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758587651; c=relaxed/simple; bh=6gl5Z+JZLYv55qqXi1LyVpN6JlxHo4rap/E6cwLJcX8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j/ocHnnLHngy6ZfevgdQMeMyqhWbQspzvjz+Z1Xj8GM0JO5Emfw+pu8X3UGYR+wVvs3nqw0B3hB+x6gC/6YnpoYokn1yp8RcV/tbKB1bdR3S25IQ2XdI1vBjM/a4fDkaJ7nrTfF15YXUZnfmiiu3L3Xkr1miEosh2qWG9D6tYhE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i9PFu55f; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i9PFu55f" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-77f169d8153so2739595b3a.3 for ; Mon, 22 Sep 2025 17:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758587649; x=1759192449; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dfDhWqoAEKFVOf/mlnVW8HkSqt5eAKrI9BC9iX0QNTA=; b=i9PFu55fxepVea1LrIKGwqJhHwgOltNX265ovIqK+p0LgeecSGdgk+0yhofBl+nKY9 jWqIz1441zvr8dHOcZ3X29uSHoIKVjf52Lqem2CuIXbUxrVFoo56lgKWl2FDaf28GSPJ pMb428UHOE9a0xqlLE6HAHKd6YQnbN5OqWP4bSVv/CJBSTtp5jK+jWowNCe6Sa75hj7B FlaVWv8G0yi5hIZsi/3O8kWo9PYD7MEvzThz/LSEt0tB1ZI0hJ1Y42PHDw4tSxCbCgfX zx6DFkix9G+DRl98ME95qjla1E2A/5aN52jwAYUaP8Zpty+gH+VbK20RgOxy77PvgcbY 1BoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758587649; x=1759192449; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dfDhWqoAEKFVOf/mlnVW8HkSqt5eAKrI9BC9iX0QNTA=; b=egBb5g1YegZ2qg8R71kttB3waz4/O4z62kAD5up1z7cINydq+meInYWWK3K2820Vu3 G0zpTJYNflLBhyQWYcDL8v8PZd4zF/JQvkZ6XGO7v/picsB4JOsSpEcoK03dUUuuVv9R M1fMctHPPmAn6d2P7Yo2p/Id2Ptg1cqA8Y9DUxgeAYezlOZMnH7c1+X/exACqGVy3zcE c+OXBmVKfp8hXoMCaqWaz2aBcFmaKDLyYslLJtGG7FYyE6bgD4zSTqHr7ZlGouBgX72x QMPJXzHUWUnDviANJdxNp7u8zQBWzZ2nzSnoCg3slcarPjWgQeozAcWSlDKpYgw96F1A AbZA== X-Forwarded-Encrypted: i=1; AJvYcCUQ1n035hMfufR9qSfoU7g93lIc8p6GHqP5sfN4bWqPtni6wdo1l6q3rdSLHiTyXNsAXYiT@lists.linux.dev X-Gm-Message-State: AOJu0YxmL9biOYD6JEJ1BUcuc1J05TrzyhLA2CGdyK0DuLlNriDK0RaQ UqL7dIXfDtJ80MZ8XCEVpnV0Y/Nn2MblF35m1gugOXQbkNmwH9uS0czk X-Gm-Gg: ASbGnctw8Z4pw7nr/U/0iU4ETnJaxp7qfN/+0goxtiERtRytZQsZH2XRWip7uWlILzH b/pcIlcoY6wl9DXC6YtZypLtEt/m9Kksx4qNorH1oiclY65UC3yVDH2yQO2uqaP8b/3YH4bRj6q KzzL2JAHOouFX0N2+8T3CBdCfULhV3g0vsc4pb9OnIK/tsrxYip7wuUK5lAuGR9/EN6+m/5VDBS S0pi0i0RhrZSieuUf30YqQNRCDnzxRS16qLQSEQsINVC+HTgt+G3GwISUiQZ9RSidevu+aywMtu eoJC/CXAkHbXp94JLobgQ5hML3Zf0Nl/GTgPw0OWX04ulkwvJolMxl7k4yChaRcE2Xs3/pRsTa0 viqdLS57ljUWfj0Wi7clfyUi5sKAFKl1nQTWExMP0FK/4LEzS X-Google-Smtp-Source: AGHT+IHwN6QET28Com0mnDzTsPnGxiZ9CeU+qh1qBSs7SYJ7KF36Ej3bcT5nNRqK/1il2tMZr28MWQ== X-Received: by 2002:a05:6a00:4fc6:b0:77f:5357:2c07 with SMTP id d2e1a72fcca58-77f53b64b19mr919389b3a.27.1758587649243; Mon, 22 Sep 2025 17:34:09 -0700 (PDT) Received: from localhost ([2a03:2880:ff:1::]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-77f4fd7223esm1127430b3a.103.2025.09.22.17.34.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Sep 2025 17:34:08 -0700 (PDT) From: Joanne Koong To: brauner@kernel.org, miklos@szeredi.hu Cc: djwong@kernel.org, hch@infradead.org, linux-block@vger.kernel.org, gfs2@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-doc@vger.kernel.org, hsiangkao@linux.alibaba.com, kernel-team@meta.com Subject: [PATCH v4 12/15] iomap: make iomap_read_folio() a void return Date: Mon, 22 Sep 2025 17:23:50 -0700 Message-ID: <20250923002353.2961514-13-joannelkoong@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20250923002353.2961514-1-joannelkoong@gmail.com> References: <20250923002353.2961514-1-joannelkoong@gmail.com> Precedence: bulk X-Mailing-List: gfs2@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit No errors are propagated in iomap_read_folio(). Change iomap_read_folio() to a void return to make this clearer to callers. Signed-off-by: Joanne Koong Reviewed-by: "Darrick J. Wong" --- fs/iomap/buffered-io.c | 9 +-------- include/linux/iomap.h | 2 +- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c index ed2acbcb81b8..9376aadb2071 100644 --- a/fs/iomap/buffered-io.c +++ b/fs/iomap/buffered-io.c @@ -450,7 +450,7 @@ static int iomap_read_folio_iter(struct iomap_iter *iter, return 0; } -int iomap_read_folio(const struct iomap_ops *ops, +void iomap_read_folio(const struct iomap_ops *ops, struct iomap_read_folio_ctx *ctx) { struct folio *folio = ctx->cur_folio; @@ -481,13 +481,6 @@ int iomap_read_folio(const struct iomap_ops *ops, if (!folio_owned) folio_unlock(folio); - - /* - * Just like mpage_readahead and block_read_full_folio, we always - * return 0 and just set the folio error flag on errors. This - * should be cleaned up throughout the stack eventually. - */ - return 0; } EXPORT_SYMBOL_GPL(iomap_read_folio); diff --git a/include/linux/iomap.h b/include/linux/iomap.h index c1a7613bca6e..f76e9b46595a 100644 --- a/include/linux/iomap.h +++ b/include/linux/iomap.h @@ -338,7 +338,7 @@ static inline bool iomap_want_unshare_iter(const struct iomap_iter *iter) ssize_t iomap_file_buffered_write(struct kiocb *iocb, struct iov_iter *from, const struct iomap_ops *ops, const struct iomap_write_ops *write_ops, void *private); -int iomap_read_folio(const struct iomap_ops *ops, +void iomap_read_folio(const struct iomap_ops *ops, struct iomap_read_folio_ctx *ctx); void iomap_readahead(const struct iomap_ops *ops, struct iomap_read_folio_ctx *ctx); -- 2.47.3