Re: [PATCH 08/14] fs: exit early in generic_update_time when there is no work

Jan Kara
2025-11-24T13:11:51Z

On Fri 14-11-25 07:26:11, Christoph Hellwig wrote:
> Exit early if not attributes are to be updated, to avoid a spurious call
^^ no

> to __mark_inode_dirty which can turn into a fairly expensive no-op due to
> the extra checks and locking.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

Honza

> ---
> fs/inode.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/inode.c b/fs/inode.c
> index 74e672dd90aa..57c458ee548d 100644
> --- a/fs/inode.c
> +++ b/fs/inode.c
> @@ -2098,6 +2098,9 @@ int generic_update_time(struct inode *inode, int flags)
> int updated = inode_update_timestamps(inode, flags);
> int dirty_flags = 0;
>
> + if (!updated)
> + return 0;
> +
> if (updated & (S_ATIME|S_MTIME|S_CTIME))
> dirty_flags = inode->i_sb->s_flags & SB_LAZYTIME ? I_DIRTY_TIME : I_DIRTY_SYNC;
> if (updated & S_VERSION)
> --
> 2.47.3
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR