Re: [PATCH 09/14] fs: factor out a mark_inode_dirty_time helper

Christoph Hellwig
2025-11-24T14:07:52Z

On Mon, Nov 24, 2025 at 02:22:59PM +0100, Jan Kara wrote:
> What I find a bit concerning here is that mark_inode_dirty_time() takes a
> different kind of flags than __mark_inode_dirty() so it's relatively easy
> to confuse. Proper typing of 'flags' would be nice here but it's a bit
> cumbersome to do in C so I'm not sure if it's worth it for this relatively
> limited use. So I guess feel free to add:

Adding a __bitwise annotation for the S_ flags seems easy enough
as there's not a whole lot of variables/arguments of that time. I can
do that as a follow-on.