Re: [PATCH 06/14] organgefs: use inode_update_timestamps directly

Jeff Layton
2025-11-14T14:06:35Z

Please do fix the spelling of orangefs in the subject line. It'll be
hard to grep for otherwise...

On Fri, 2025-11-14 at 07:26 +0100, Christoph Hellwig wrote:
> Orangefs has no i_version handling and __orangefs_setattr already
> explicitly marks the inode dirty. So instead of the using
> the flags return value from generic_update_time, just call the
> lower level inode_update_timestamps helper directly.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/orangefs/inode.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/orangefs/inode.c b/fs/orangefs/inode.c
> index a01400cd41fd..55f6c8026812 100644
> --- a/fs/orangefs/inode.c
> +++ b/fs/orangefs/inode.c
> @@ -878,7 +878,9 @@ int orangefs_update_time(struct inode *inode, int flags)
>
> gossip_debug(GOSSIP_INODE_DEBUG, "orangefs_update_time: %pU\n",
> get_khandle_from_ino(inode));
> - flags = generic_update_time(inode, flags);
> +
> + flags = inode_update_timestamps(inode, flags);
> +
> memset(&iattr, 0, sizeof iattr);
> if (flags & S_ATIME)
> iattr.ia_valid |= ATTR_ATIME;

--
Jeff Layton <jlayton@kernel.org>