From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4227E30C632
	for <gfs2@lists.linux.dev>; Mon, 24 Nov 2025 14:07:52 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1763993274; cv=none; b=kcCIGdk12stNGt8wbQQM8RjnLH6lW7r+AeZeA4ZhiJx0Gt4B+pVuGO8awnMl+t+H5sMzJAiitXncg8t/u9iKOt8Zgy9VmwYdLS6L5hH6MNHyerO9ozCmPuBxBjlrbLFIAMF2YOcQaR//Yx0L6YZbcRzkjYr7IO2+VSnCJrDP+d0=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1763993274; c=relaxed/simple;
	bh=P9EdTF1MezUbkGSY3Ff+pcwlx5yl4Irjd0IA0naJ6n0=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=l1o1c6nYNG0v+HS9XGvslveI1UrrZWiR1BgT7OYlZWLfWa2M8cnLmQzlM+VH2Ypu1DT62hzSj6xTMcT9NJAofwIbZvwJG1MDp6SIuyOozC0RxQe2R3dMenx2QsReesMgaH2HRASAf2ztMKl3sHHIRPtVUdgvl+HSUirkscmqkgs=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de
Received: by verein.lst.de (Postfix, from userid 2407)
	id A379A68B05; Mon, 24 Nov 2025 15:07:47 +0100 (CET)
Date: Mon, 24 Nov 2025 15:07:46 +0100
From: Christoph Hellwig <hch@lst.de>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@lst.de>, Christian Brauner <brauner@kernel.org>,
	Al Viro <viro@zeniv.linux.org.uk>, David Sterba <dsterba@suse.com>,
	Mike Marshall <hubcap@omnibond.com>,
	Martin Brandenburg <martin@omnibond.com>,
	Carlos Maiolino <cem@kernel.org>, Stefan Roesch <shr@fb.com>,
	Jeff Layton <jlayton@kernel.org>, linux-kernel@vger.kernel.org,
	linux-btrfs@vger.kernel.org, gfs2@lists.linux.dev,
	io-uring@vger.kernel.org, devel@lists.orangefs.org,
	linux-unionfs@vger.kernel.org, linux-mtd@lists.infradead.org,
	linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 09/14] fs: factor out a mark_inode_dirty_time helper
Message-ID: <20251124140746.GA14417@lst.de>
References: <20251114062642.1524837-1-hch@lst.de> <20251114062642.1524837-10-hch@lst.de> <fbym7i2zelbatxbhy5eeffwpa3ni7bstjddbf7ran7djzthwjo@kfxj3wrxeuou>
Precedence: bulk
X-Mailing-List: gfs2@lists.linux.dev
List-Id: <gfs2.lists.linux.dev>
List-Subscribe: <mailto:gfs2+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:gfs2+unsubscribe@lists.linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fbym7i2zelbatxbhy5eeffwpa3ni7bstjddbf7ran7djzthwjo@kfxj3wrxeuou>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Mon, Nov 24, 2025 at 02:22:59PM +0100, Jan Kara wrote:
> What I find a bit concerning here is that mark_inode_dirty_time() takes a
> different kind of flags than __mark_inode_dirty() so it's relatively easy
> to confuse. Proper typing of 'flags' would be nice here but it's a bit
> cumbersome to do in C so I'm not sure if it's worth it for this relatively
> limited use. So I guess feel free to add:

Adding a __bitwise annotation for the S_ flags seems easy enough
as there's not a whole lot of variables/arguments of that time.  I can
do that as a follow-on.