From: alexs@kernel.org
To: Alexander Aring <aahringo@redhat.com>,
David Teigland <teigland@redhat.com>,
gfs2@lists.linux.dev (open list:DISTRIBUTED LOCK MANAGER (DLM)),
linux-kernel@vger.kernel.org (open list)
Cc: Alex Shi <alexs@kernel.org>, gfs2@lists.linux.dev
Subject: [RFC PATCH] fs/dlm/dir: remove unuse varible count_match
Date: Wed, 7 Jan 2026 15:30:14 +0800 [thread overview]
Message-ID: <20260107073015.16562-1-alexs@kernel.org> (raw)
From: Alex Shi <alexs@kernel.org>
The variable was never used after introduced. Better to comment it if we
want to keep the info.
fs/dlm/dir.c:65:26: error: variable 'count_match' set but not used [-Werror,-Wunused-but-set-variable]
65 | unsigned int count = 0, count_match = 0, count_bad = 0, count_add = 0;
| ^
1 error generated.
Signed-off-by: Alex Shi <alexs@kernel.org>
Cc: gfs2@lists.linux.dev
Cc: Alexander Aring <aahringo@redhat.com>
Cc: David Teigland <teigland@redhat.com>
---
fs/dlm/dir.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/dlm/dir.c b/fs/dlm/dir.c
index b1ab0adbd9d0..01c292379f5b 100644
--- a/fs/dlm/dir.c
+++ b/fs/dlm/dir.c
@@ -62,7 +62,7 @@ int dlm_recover_directory(struct dlm_ls *ls, uint64_t seq)
char *b, *last_name = NULL;
int error = -ENOMEM, last_len, nodeid, result;
uint16_t namelen;
- unsigned int count = 0, count_match = 0, count_bad = 0, count_add = 0;
+ unsigned int count = 0, count_bad = 0, count_add = 0;
log_rinfo(ls, "dlm_recover_directory");
@@ -157,12 +157,12 @@ int dlm_recover_directory(struct dlm_ls *ls, uint64_t seq)
}
/* The name was found in rsbtbl, and the
- * master nodeid matches memb->nodeid. */
+ * master nodeid matches memb->nodeid.
if (result == DLM_LU_MATCH &&
nodeid == memb->nodeid) {
count_match++;
- }
+ }*/
/* The name was not found in rsbtbl and was
* added with memb->nodeid as the master. */
--
2.43.0
next reply other threads:[~2026-01-07 7:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 7:30 alexs [this message]
2026-01-07 14:14 ` [RFC PATCH] fs/dlm/dir: remove unuse varible count_match Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260107073015.16562-1-alexs@kernel.org \
--to=alexs@kernel.org \
--cc=aahringo@redhat.com \
--cc=gfs2@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox